Bug 1121623 part 5. Remove PerformanceEntry::WrapObject. r=peterv
authorBoris Zbarsky <bzbarsky@mit.edu>
Fri, 24 May 2019 07:23:47 +0000
changeset 475387 1e7a53dbff7b0a55633a7b57c4229259f47cd492
parent 475386 4d9f7977a103255ef5d9e9424b6233482b25c304
child 475388 47671db885266d07d84f67dc80474c23bd72e47e
push id36060
push usercbrindusan@mozilla.com
push dateFri, 24 May 2019 21:47:21 +0000
treeherdermozilla-central@ac95bdf3c0b3 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspeterv
bugs1121623
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1121623 part 5. Remove PerformanceEntry::WrapObject. r=peterv It's dead code, because we never create PerformanceEntry objects directly and subclasses override WrapObject. Differential Revision: https://phabricator.services.mozilla.com/D32203
dom/performance/PerformanceEntry.cpp
dom/performance/PerformanceEntry.h
--- a/dom/performance/PerformanceEntry.cpp
+++ b/dom/performance/PerformanceEntry.cpp
@@ -1,17 +1,16 @@
 /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 #include "PerformanceEntry.h"
 #include "MainThreadUtils.h"
-#include "mozilla/dom/PerformanceEntryBinding.h"
 #include "nsIURI.h"
 
 using namespace mozilla::dom;
 
 NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(PerformanceEntry, mParent)
 
 NS_IMPL_CYCLE_COLLECTING_ADDREF(PerformanceEntry)
 NS_IMPL_CYCLE_COLLECTING_RELEASE(PerformanceEntry)
@@ -22,21 +21,16 @@ NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(
 NS_INTERFACE_MAP_END
 
 PerformanceEntry::PerformanceEntry(nsISupports* aParent, const nsAString& aName,
                                    const nsAString& aEntryType)
     : mParent(aParent), mName(aName), mEntryType(aEntryType) {}
 
 PerformanceEntry::~PerformanceEntry() {}
 
-JSObject* PerformanceEntry::WrapObject(JSContext* aCx,
-                                       JS::Handle<JSObject*> aGivenProto) {
-  return mozilla::dom::PerformanceEntry_Binding::Wrap(aCx, this, aGivenProto);
-}
-
 size_t PerformanceEntry::SizeOfExcludingThis(
     mozilla::MallocSizeOf aMallocSizeOf) const {
   return mName.SizeOfExcludingThisIfUnshared(aMallocSizeOf) +
          mEntryType.SizeOfExcludingThisIfUnshared(aMallocSizeOf);
 }
 
 size_t PerformanceEntry::SizeOfIncludingThis(
     mozilla::MallocSizeOf aMallocSizeOf) const {
--- a/dom/performance/PerformanceEntry.h
+++ b/dom/performance/PerformanceEntry.h
@@ -24,19 +24,16 @@ class PerformanceEntry : public nsISuppo
 
  public:
   PerformanceEntry(nsISupports* aParent, const nsAString& aName,
                    const nsAString& aEntryType);
 
   NS_DECL_CYCLE_COLLECTING_ISUPPORTS
   NS_DECL_CYCLE_COLLECTION_SCRIPT_HOLDER_CLASS(PerformanceEntry)
 
-  virtual JSObject* WrapObject(JSContext* aCx,
-                               JS::Handle<JSObject*> aGivenProto) override;
-
   nsISupports* GetParentObject() const { return mParent; }
 
   void GetName(nsAString& aName) const { aName = mName; }
 
   const nsAString& GetName() const { return mName; }
 
   void SetName(const nsAString& aName) { mName = aName; }