Bug 1417309 - Remove the nscore.h include from basictypes.h. r=froydnj
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 15 Nov 2017 13:46:02 +0900
changeset 392144 1e648d0142777e06c6b4bddc51be0e918c93afe3
parent 392143 74a6998f7206ed69b56b290a5eed70f187eb50ac
child 392145 c995692a3c92e3fc2e31849c25eb8da49afa1326
push id32911
push userrgurzau@mozilla.com
push dateThu, 16 Nov 2017 10:05:12 +0000
treeherdermozilla-central@92235deefc25 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1417309
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1417309 - Remove the nscore.h include from basictypes.h. r=froydnj This is a hack that was added back when the chromium ipc codebase was imported, but that shouldn't be required anymore. The mozalloc operator new is gotten through stl wrapping these days.
ipc/chromium/src/base/basictypes.h
--- a/ipc/chromium/src/base/basictypes.h
+++ b/ipc/chromium/src/base/basictypes.h
@@ -261,12 +261,9 @@ enum Ownership {
 //       explicit MyClass(base::LinkerInitialized x) {}
 // and invoked as
 //       static MyClass my_variable_name(base::LINKER_INITIALIZED);
 namespace base {
 enum LinkerInitialized { LINKER_INITIALIZED };
 }  // base
 
 
-#include "nscore.h"             // pick up mozalloc operator new() etc.
-
-
 #endif  // BASE_BASICTYPES_H_