Bug 756066 - Make StorageEventInit.key nullable; r=mayhemer
authorMs2ger <ms2ger@gmail.com>
Fri, 25 May 2012 09:18:31 +0200
changeset 94823 1dd0c5c6d9fd066d28d8e44c4542e3f71d529bbb
parent 94822 561bfacbefeebaa26cba5735c4c42cacc7dcb950
child 94824 0d1dcdf58ffb422361f7da3e5557eedd73db2700
child 94944 6d8518b1dae2a1d519a6f88da33182843ca10f1e
push id22760
push userMs2ger@gmail.com
push dateFri, 25 May 2012 07:19:32 +0000
treeherdermozilla-central@1dd0c5c6d9fd [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmayhemer
bugs756066
milestone15.0a1
first release with
nightly linux32
1dd0c5c6d9fd / 15.0a1 / 20120525030517 / files
nightly linux64
1dd0c5c6d9fd / 15.0a1 / 20120525030517 / files
nightly mac
1dd0c5c6d9fd / 15.0a1 / 20120525030517 / files
nightly win32
1dd0c5c6d9fd / 15.0a1 / 20120525030517 / files
nightly win64
1dd0c5c6d9fd / 15.0a1 / 20120525030517 / files
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
releases
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 756066 - Make StorageEventInit.key nullable; r=mayhemer
content/events/test/test_eventctors.html
dom/imptests/failures/webapps/WebStorage/tests/submissions/Infraware/Makefile.in
dom/imptests/failures/webapps/WebStorage/tests/submissions/Infraware/test_event_constructor.html.json
dom/imptests/failures/webapps/WebStorage/tests/submissions/Ms2ger/Makefile.in
dom/imptests/failures/webapps/WebStorage/tests/submissions/Ms2ger/test_event_constructor_js.html.json
dom/interfaces/storage/nsIDOMStorageEvent.idl
--- a/content/events/test/test_eventctors.html
+++ b/content/events/test/test_eventctors.html
@@ -341,17 +341,17 @@ try {
 ok(ex, "First parameter is required!");
 ex = false;
 
 e = new StorageEvent("hello");
 ok(e.type, "hello", "Wrong event type!");
 ok(!e.isTrusted, "Event shouldn't be trusted!");
 ok(!e.bubbles, "Event shouldn't bubble!");
 ok(!e.cancelable, "Event shouldn't be cancelable!");
-is(e.key, "", "key should be ''");
+is(e.key, null, "key should be null");
 is(e.oldValue, null, "oldValue should be null");
 is(e.newValue, null, "newValue should be null");
 is(e.url, "", "url should be ''");
 document.dispatchEvent(e);
 is(receivedEvent, e, "Wrong event!");
 
 e = new StorageEvent("hello",
   { bubbles: true, cancelable: true, key: "key",
--- a/dom/imptests/failures/webapps/WebStorage/tests/submissions/Infraware/Makefile.in
+++ b/dom/imptests/failures/webapps/WebStorage/tests/submissions/Infraware/Makefile.in
@@ -7,14 +7,13 @@ relativesrcdir = dom/imptests/failures/w
 
 DIRS = \
   $(NULL)
 
 include $(DEPTH)/config/autoconf.mk
 include $(topsrcdir)/config/rules.mk
 
 _TESTS = \
-  test_event_constructor.html.json \
   test_storage_local_security.html.json \
   $(NULL)
 
 libs:: $(_TESTS)
 	$(INSTALL) $(foreach f,$^,"$f") $(DEPTH)/_tests/testing/mochitest/tests/$(relativesrcdir)
deleted file mode 100644
--- a/dom/imptests/failures/webapps/WebStorage/tests/submissions/Infraware/test_event_constructor.html.json
+++ /dev/null
@@ -1,3 +0,0 @@
-{
-  "storageeventinit test": true
-}
--- a/dom/imptests/failures/webapps/WebStorage/tests/submissions/Ms2ger/Makefile.in
+++ b/dom/imptests/failures/webapps/WebStorage/tests/submissions/Ms2ger/Makefile.in
@@ -7,17 +7,16 @@ relativesrcdir = dom/imptests/failures/w
 
 DIRS = \
   $(NULL)
 
 include $(DEPTH)/config/autoconf.mk
 include $(topsrcdir)/config/rules.mk
 
 _TESTS = \
-  test_event_constructor_js.html.json \
   test_storage_local_in_js.html.json \
   test_storage_local_removeitem_js.html.json \
   test_storage_session_in_js.html.json \
   test_storage_session_removeitem_js.html.json \
   $(NULL)
 
 libs:: $(_TESTS)
 	$(INSTALL) $(foreach f,$^,"$f") $(DEPTH)/_tests/testing/mochitest/tests/$(relativesrcdir)
deleted file mode 100644
--- a/dom/imptests/failures/webapps/WebStorage/tests/submissions/Ms2ger/test_event_constructor_js.html.json
+++ /dev/null
@@ -1,3 +0,0 @@
-{
-  "StorageEvent constructor and nulls": true
-}
--- a/dom/interfaces/storage/nsIDOMStorageEvent.idl
+++ b/dom/interfaces/storage/nsIDOMStorageEvent.idl
@@ -60,14 +60,14 @@ interface nsIDOMStorageEvent : nsIDOMEve
                         in DOMString oldValueArg,
                         in DOMString newValueArg,
                         in DOMString urlArg,
                         in nsIDOMStorage storageAreaArg);
 };
 
 dictionary StorageEventInit : EventInit
 {
-  DOMString key;
+  DOMString? key;
   DOMString? oldValue;
   DOMString? newValue;
   DOMString url;
   nsIDOMStorage storageArea;
 };