Bug 867372 - Mach gtest doesn't work with default test filter on windows. r=gps NPOTB
authorBenoit Girard <b56girard@gmail.com>
Wed, 01 May 2013 16:54:08 -0400
changeset 130536 1d82018a97724792f3d5ee772b4485f18f40d3c4
parent 130535 3b76894efafa7853f88f1ba9cd35ab81e830b7d7
child 130537 024eef52799d14a434e4e17f6616720859f7dc70
push id24621
push userphilringnalda@gmail.com
push dateThu, 02 May 2013 03:27:34 +0000
treeherdermozilla-central@0274ab3783b1 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps
bugs867372
milestone23.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 867372 - Mach gtest doesn't work with default test filter on windows. r=gps NPOTB
python/mozbuild/mozbuild/mach_commands.py
--- a/python/mozbuild/mozbuild/mach_commands.py
+++ b/python/mozbuild/mozbuild/mach_commands.py
@@ -286,17 +286,17 @@ class Warnings(MachCommandBase):
                     warning['column'], warning['flag'], warning['message']))
             else:
                 print('%s:%d [%s] %s' % (filename, warning['line'],
                     warning['flag'], warning['message']))
 
 @CommandProvider
 class GTestCommands(MachCommandBase):
     @Command('gtest', help='Run GTest unit tests.')
-    @CommandArgument('gtest_filter', default='*', nargs='?', metavar='gtest_filter',
+    @CommandArgument('gtest_filter', default=b"*", nargs='?', metavar='gtest_filter',
         help="test_filter is a ':'-separated list of wildcard patterns (called the positive patterns),"
              "optionally followed by a '-' and another ':'-separated pattern list (called the negative patterns).")
     @CommandArgument('--jobs', '-j', default='1', nargs='?', metavar='jobs', type=int,
         help='Run the tests in parallel using multiple processes.')
     @CommandArgument('--tbpl-parser', '-t', action='store_true',
         help='Output test results in a format that can be parsed by TBPL.')
     @CommandArgument('--shuffle', '-s', action='store_true',
         help='Randomize the execution order of tests.')