Bug 1587206 - [lint.flake8] Enable F633 across the tree, r=sylvestre
authorAndrew Halberstadt <ahalberstadt@mozilla.com>
Thu, 10 Oct 2019 18:50:52 +0000
changeset 497262 1d6d7e7ddbbd5f7ba324621630a7a7e59db82dfc
parent 497261 2921dbcceadc9adb0f12188f62a8f86bd18b0f93
child 497263 b4d2e6a7f790f58b6766686bc445332d53971052
push id36681
push usercbrindusan@mozilla.com
push dateFri, 11 Oct 2019 21:50:12 +0000
treeherdermozilla-central@c5e6477c3a24 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerssylvestre
bugs1587206
milestone71.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1587206 - [lint.flake8] Enable F633 across the tree, r=sylvestre This prevents '>>' with print statements. Since this syntax is still valid in Python 2, I exluded dirs that contain this error rather than fix them. Depends on D48609 Differential Revision: https://phabricator.services.mozilla.com/D48610
.flake8
--- a/.flake8
+++ b/.flake8
@@ -88,42 +88,45 @@ exclude =
     tools/crashreporter/*.configure,
     .ycm_extra_conf.py,
 
 # See:
 #   - http://flake8.pycqa.org/en/latest/user/error-codes.html
 #   - http://pep8.readthedocs.io/en/latest/intro.html#configuration
 ignore =
     # These should be triaged and either fixed or moved to the list below.
-    F633, F811, E117, W504, W605, W606,
+    F811, E117, W504, W605, W606,
     # These are intentionally disabled (not necessarily for good reason).
     #   F723: syntax error in type comment
     #       text contains quotes which breaks our custom JSON formatter
     F723, E121, E123, E126, E129, E133, E226, E241, E242, E402, E704, E741, W503,
 
 per-file-ignores =
     ipc/ipdl/*: F403, F405
     # cpp_eclipse has a lot of multi-line embedded XML which exceeds line length
     python/mozbuild/mozbuild/backend/cpp_eclipse.py: E501
     testing/firefox-ui/**/__init__.py: F401
     testing/marionette/**/__init__.py: F401
     testing/mozharness/configs/*: E124, E127, E128, E131, E231, E261, E265, E266, E501, W391
 
     # These paths contain Python-2 only syntax which cause errors since flake8
     # is run with Python 3.
-    build/**: F821
-    config/**: F821
-    js/**: F821
+    browser/app/macversion.py: F633
+    build/**: F633, F821
+    config/**: F633, F821
+    ipc/pull-chromium.py: F633
+    js/**: F633, F821
     memory/**: F821
     mozglue/**: F821
     python/mozbuild/**: F821
     python/mozversioncontrol/**: F821
     taskcluster/**: F821
     testing/mozharness/**: F821
     testing/raptor/**: F821
     testing/talos/**: F821
     toolkit/components/telemetry/**: F821
     tools/tryselect/**: F821
     testing/firefox-ui/tests/functional/safebrowsing/test_initial_download.py: F821
+    testing/gtest/rungtests.py: F633
     testing/marionette/**: F821
     testing/mochitest/**: F821
-    testing/xpcshell/**: F821
-    xpcom/idl-parser/xpidl/**: F821
+    testing/xpcshell/**: F633, F821
+    xpcom/idl-parser/xpidl/**: F633, F821