Bug 1262331 - Fix mach valgrind-test logging. r=gps
authorMike Hommey <mh+mozilla@glandium.org>
Wed, 06 Apr 2016 11:01:56 +0900
changeset 291990 1d6d31b41c2fb93f3172d6ef2ef560e8686cf74c
parent 291989 e4b714836b2342c14df2a69a5980dd5a5202da27
child 291991 ab03da27fcb70e9088a6e49cd178491de5175678
push id30149
push usercbook@mozilla.com
push dateThu, 07 Apr 2016 09:52:31 +0000
treeherdermozilla-central@b6683e141c47 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgps
bugs1262331
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1262331 - Fix mach valgrind-test logging. r=gps Valgrind-test's output handler buffers valgrind's output to detect errors and emit proper messages that are detected by automation log parsing. When an error is detected, the buffered output is reinjected, but there was a typo that prevented that from actually happening, which ate the first lines of stack traces.
build/valgrind/output_handler.py
--- a/build/valgrind/output_handler.py
+++ b/build/valgrind/output_handler.py
@@ -101,16 +101,16 @@ class OutputHandler(object):
             else:
                 # We've finished getting the first few stack entries. Print the
                 # failure message and the buffered lines, and then reset state.
                 self.logger(logging.ERROR, 'valgrind-error-msg',
                             {'error': self.curr_error,
                              'location': self.curr_location},
                              'TEST-UNEXPECTED-FAIL | valgrind-test | {error} at {location}')
                 for b in self.buffered_lines:
-                    self.log(line)
+                    self.log(b)
                 self.curr_error = None
                 self.curr_location = None
                 self.buffered_lines = None
 
         if re.match(self.re_suppression, line):
             self.suppression_count += 1