Bug 1472254 - Backed out changeset 69259eedc1e6 as the final fix has landed. r=dmajor
authorMasatoshi Kimura <VYV03354@nifty.ne.jp>
Fri, 10 Aug 2018 18:42:10 +0900
changeset 430971 1d475ec08b135446685a267b9a0e8d876a3d4c7f
parent 430970 059d023837068e124e35966c20eb87216b481ec5
child 430972 61e553ff703e2d93db2f03aa901d1976e8084723
child 431003 3f41992ab77ee921028fb0e05b719e128eb9ec71
push id34417
push usernbeleuzu@mozilla.com
push dateFri, 10 Aug 2018 16:00:49 +0000
treeherdermozilla-central@61e553ff703e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdmajor
bugs1472254
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1472254 - Backed out changeset 69259eedc1e6 as the final fix has landed. r=dmajor
old-configure.in
--- a/old-configure.in
+++ b/old-configure.in
@@ -1028,19 +1028,16 @@ case "$target" in
             # which clang-cl doesn't understand.
             CXXFLAGS="$CXXFLAGS -Wno-ignored-attributes"
             # __attribute__((unused)) really means "might be unused" and
             # we use it to avoid warnings about things that are unused
             # in some compilation units, but used in many others.  This
             # warning insists on complaining about the latter case, which
             # is annoying, and rather noisy.
             CXXFLAGS="$CXXFLAGS -Wno-used-but-marked-unused"
-            # Work around until bug 1472254 is fixed.
-            CFLAGS="$CFLAGS -Wno-pragma-pack"
-            CXXFLAGS="$CXXFLAGS -Wno-pragma-pack"
         fi
         # make 'foo == bar;' error out
         CFLAGS="$CFLAGS -we4553"
         CXXFLAGS="$CXXFLAGS -we4553"
         # Silence VS2017 15.5+ TR1 deprecation warnings hit by older gtest versions
         CXXFLAGS="$CXXFLAGS -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING"
         LIBS="$LIBS kernel32.lib user32.lib gdi32.lib winmm.lib wsock32.lib advapi32.lib secur32.lib"
         MOZ_DEBUG_LDFLAGS='-DEBUG -DEBUGTYPE:CV'