Bug 1417646 - Remove explicit ac_add_options --enable-geckodriver for linux32 build. r=me
☠☠ backed out by 5b7d48d3b143 ☠ ☠
authorHiroyuki Ikezoe <hikezoe@mozilla.com>
Thu, 30 Aug 2018 18:08:45 +0900
changeset 434066 1c7e3f8af2e33ed2321a715f6381bac48ca678d9
parent 434065 42ea09d91d7e0889c831b4c1b4dda4ffc877616c
child 434067 9b452b8c8d137f8f030f31351be89887a82ffca7
push id34537
push usernbeleuzu@mozilla.com
push dateThu, 30 Aug 2018 16:59:14 +0000
treeherdermozilla-central@c317d6b31d9c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1417646
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1417646 - Remove explicit ac_add_options --enable-geckodriver for linux32 build. r=me
build/unix/mozconfig.linux32
--- a/build/unix/mozconfig.linux32
+++ b/build/unix/mozconfig.linux32
@@ -1,15 +1,8 @@
 . "$topsrcdir/build/unix/mozconfig.linux"
 
 export MOZ_LINUX_32_SSE2_STARTUP_ERROR=1
 
 CFLAGS="$CFLAGS -march=pentium-m -msse -msse2 -mfpmath=sse"
 CXXFLAGS="$CXXFLAGS -march=pentium-m -msse -msse2 -mfpmath=sse"
 
 ac_add_options --target=i686-pc-linux
-
-# The linux32 builds are effectively cross-compilations, and geckodriver
-# is not enabled by default on cross-compilations, because in most cases,
-# the target is not something we can run binaries of, and geckodriver
-# is a target binary instead of a host binary. But for linux32, we actually
-# can run the target binaries, so we can manually enable geckodriver.
-ac_add_options --enable-geckodriver