No bug - Move the bool specialization of PrimitiveConversionTraits from between the integer ones.
authorMs2ger <ms2ger@gmail.com>
Thu, 06 Sep 2012 09:20:29 +0200
changeset 104381 1c616799d242ee169783ddd1f9cba3e89f920acb
parent 104380 f1265ac5dbc0bda9ef923c77e3be4c4770600b8f
child 104382 7682c01baef38245340c7b98a3bbc52dc358dcd2
push id23421
push userMs2ger@gmail.com
push dateThu, 06 Sep 2012 08:20:50 +0000
treeherdermozilla-central@47126ccdb660 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
milestone18.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No bug - Move the bool specialization of PrimitiveConversionTraits from between the integer ones.
dom/bindings/PrimitiveConversions.h
--- a/dom/bindings/PrimitiveConversions.h
+++ b/dom/bindings/PrimitiveConversions.h
@@ -72,26 +72,16 @@ struct PrimitiveConversionTraits<uint16_
 template<>
 struct PrimitiveConversionTraits<int32_t> : PrimitiveConversionTraits_smallInt {
 };
 template<>
 struct PrimitiveConversionTraits<uint32_t> : PrimitiveConversionTraits_smallInt {
 };
 
 template<>
-struct PrimitiveConversionTraits<bool> {
-  typedef JSBool jstype;
-  typedef bool intermediateType;
-  static inline bool converter(JSContext* /* unused */, JS::Value v, jstype* retval) {
-    *retval = JS::ToBoolean(v);
-    return true;
-  }
-};
-
-template<>
 struct PrimitiveConversionTraits<int64_t> {
   typedef int64_t jstype;
   typedef int64_t intermediateType;
   static inline bool converter(JSContext* cx, JS::Value v, jstype* retval) {
     return JS::ToInt64(cx, v, retval);
   }
 };
 
@@ -99,16 +89,26 @@ template<>
 struct PrimitiveConversionTraits<uint64_t> {
   typedef uint64_t jstype;
   typedef uint64_t intermediateType;
   static inline bool converter(JSContext* cx, JS::Value v, jstype* retval) {
     return JS::ToUint64(cx, v, retval);
   }
 };
 
+template<>
+struct PrimitiveConversionTraits<bool> {
+  typedef JSBool jstype;
+  typedef bool intermediateType;
+  static inline bool converter(JSContext* /* unused */, JS::Value v, jstype* retval) {
+    *retval = JS::ToBoolean(v);
+    return true;
+  }
+};
+
 struct PrimitiveConversionTraits_float {
   typedef double jstype;
   typedef double intermediateType;
   static inline bool converter(JSContext* cx, JS::Value v, jstype* retval) {
     return JS::ToNumber(cx, v, retval);
   }
 };
 template<>