Bug 1449571 - Re-enable JS_CRASH_DIAGNOSTICS on ASan builds. r=ehsan
authorJan de Mooij <jdemooij@mozilla.com>
Thu, 29 Mar 2018 09:14:11 +0200
changeset 410669 1b653c3d140dc9ffac791271930b8d2ad8d29405
parent 410668 ec5d5e59074b0be7adb4f5e6cebf9c2e414adf93
child 410670 8c1967a96814f6374c3a32f29b71f437df57120c
push id33734
push useraciure@mozilla.com
push dateThu, 29 Mar 2018 22:07:07 +0000
treeherdermozilla-central@dcd10220d55a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersehsan
bugs1449571
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1449571 - Re-enable JS_CRASH_DIAGNOSTICS on ASan builds. r=ehsan
js/src/jsutil.h
--- a/js/src/jsutil.h
+++ b/js/src/jsutil.h
@@ -313,17 +313,17 @@ Poison(void* ptr, uint8_t value, size_t 
     }
 #else // !DEBUG
     memset(ptr, value, num);
 #endif // !DEBUG
     return ptr;
 }
 
 /* Crash diagnostics by default in debug and on nightly channel. */
-#if (defined(DEBUG) || defined(NIGHTLY_BUILD)) && !defined(MOZ_ASAN)
+#if defined(DEBUG) || defined(NIGHTLY_BUILD)
 # define JS_CRASH_DIAGNOSTICS 1
 #endif
 
 /* Enable poisoning in crash-diagnostics and zeal builds. */
 #if defined(JS_CRASH_DIAGNOSTICS) || defined(JS_GC_ZEAL)
 # define JS_POISON(p, val, size) Poison(p, val, size)
 # define JS_GC_POISONING 1
 #else