Bug 1287684 - Report HTMLMediaElement telemetry for non-MSE - r=rillian
authorGerald Squelart <gsquelart@mozilla.com>
Tue, 19 Jul 2016 14:33:55 +1000
changeset 305529 1b135c0869e1aa0fba03801d3fd6bf43e1e3cd7e
parent 305528 067b8bda91edf07737a97e094677810c3156853e
child 305530 5bdb5eb0d9f5afde117c306f7545282e873eab7c
push id30465
push usercbook@mozilla.com
push dateWed, 20 Jul 2016 09:00:59 +0000
treeherdermozilla-central@3383b0da1a14 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersrillian
bugs1287684
milestone50.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1287684 - Report HTMLMediaElement telemetry for non-MSE - r=rillian Removed test blocking execution of ReportTelemetry in non-MSE case. EME currently depends on MSE, so ReportEMETelemetry won't do anything in the non-MSE case anyway. But I think it's good to remove the MSE test as well, in case we change that limitation in the future. MozReview-Commit-ID: 8sTg5F13KMs
dom/html/HTMLMediaElement.cpp
--- a/dom/html/HTMLMediaElement.cpp
+++ b/dom/html/HTMLMediaElement.cpp
@@ -4712,22 +4712,20 @@ void HTMLMediaElement::SuspendOrResumeEl
   LOG(LogLevel::Debug, ("%p SuspendOrResumeElement(pause=%d, suspendEvents=%d) hidden=%d",
       this, aPauseElement, aSuspendEvents, OwnerDoc()->Hidden()));
 
   if (aPauseElement != mPausedForInactiveDocumentOrChannel) {
     mPausedForInactiveDocumentOrChannel = aPauseElement;
     UpdateSrcMediaStreamPlaying();
     UpdateAudioChannelPlayingState();
     if (aPauseElement) {
-      if (mMediaSource) {
-        ReportTelemetry();
+      ReportTelemetry();
 #ifdef MOZ_EME
-        ReportEMETelemetry();
+      ReportEMETelemetry();
 #endif
-      }
 
 #ifdef MOZ_EME
       // For EME content, force destruction of the CDM client (and CDM
       // instance if this is the last client for that CDM instance) and
       // the CDM's decoder. This ensures the CDM gets reliable and prompt
       // shutdown notifications, as it may have book-keeping it needs
       // to do on shutdown.
       if (mMediaKeys) {