author | Brian R. Bondy <netzen@gmail.com> |
Tue, 03 Mar 2015 23:27:17 -0500 (2015-03-04) | |
changeset 237698 | 1aaa76c1c3ad6466aeeb9b56bc7d20c6a1b05167 |
parent 237697 | fc00de5d587f9007945ac896a99314919eb26955 |
child 237699 | 883e17fc475fb4589524876f7630a0345780e38e |
push id | 28546 |
push user | netzen@gmail.com |
push date | Mon, 06 Apr 2015 16:08:39 +0000 (2015-04-06) |
treeherder | mozilla-central@883e17fc475f [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | rstrong |
bugs | 973933 |
milestone | 40.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
--- a/toolkit/mozapps/update/updater/moz.build +++ b/toolkit/mozapps/update/updater/moz.build @@ -3,10 +3,11 @@ # This Source Code Form is subject to the terms of the Mozilla Public # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. Program('updater') updater_rel_path = '' include('updater-common.build') -DIRS += ['updater-xpcshell'] +if CONFIG['ENABLE_TESTS']: + DIRS += ['updater-xpcshell'] FAIL_ON_WARNINGS = True
--- a/toolkit/mozapps/update/updater/updater-common.build +++ b/toolkit/mozapps/update/updater/updater-common.build @@ -42,21 +42,21 @@ if CONFIG['OS_ARCH'] == 'WINNT': 'ws2_32', 'shell32', 'shlwapi', 'crypt32', 'advapi32', ] elif CONFIG['OS_ARCH'] == 'Linux' and CONFIG['MOZ_VERIFY_MAR_SIGNATURE']: USE_LIBS += [ - '/modules/libmar/sign/signmar', 'nss', + 'signmar', 'updatecommon', ] - OS_LIBS += CONFIG['NSPR_LIBS'] + OS_LIBS += CONFIG['nspr'] else: USE_LIBS += [ 'updatecommon', ] USE_LIBS += [ 'mar', ] @@ -75,17 +75,20 @@ if CONFIG['MOZ_ENABLE_GTK']: ] if CONFIG['MOZ_WIDGET_TOOLKIT'] == 'cocoa': have_progressui = 1 srcs += [ 'launchchild_osx.mm', 'progressui_osx.mm', ] - OS_LIBS += ['-framework Cocoa -framework Security'] + OS_LIBS += [ + '-framework Cocoa', + '-framework Security', + ] elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'gonk': have_progressui = 1 srcs += [ 'automounter_gonk.cpp', 'progressui_gonk.cpp', ] DISABLE_STL_WRAPPING = True OS_LIBS += [ @@ -93,18 +96,17 @@ elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'go 'sysutils', ] if have_progressui == 0: srcs += [ 'progressui_null.cpp', ] -srcs.sort() -SOURCES += ['%s%s' % (updater_rel_path, f) for f in srcs] +SOURCES += ['%s%s' % (updater_rel_path, f) for f in sorted(srcs)] DEFINES['NS_NO_XPCOM'] = True DISABLE_STL_WRAPPING = True for var in ('MAR_CHANNEL_ID', 'MOZ_APP_VERSION'): DEFINES[var] = '"%s"' % CONFIG[var] LOCAL_INCLUDES += [ '/toolkit/mozapps/update/common',
--- a/toolkit/mozapps/update/updater/updater-xpcshell/Makefile.in +++ b/toolkit/mozapps/update/updater/updater-xpcshell/Makefile.in @@ -3,55 +3,40 @@ # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. # For changes here, also consider ../Makefile.in XPCSHELLTESTROOT = $(abspath $(DEPTH))/_tests/xpcshell/toolkit/mozapps/update/tests MOCHITESTROOT = $(abspath $(DEPTH))/_tests/testing/mochitest/chrome/toolkit/mozapps/update/tests -ifndef MOZ_PROFILE_GENERATE -ifdef COMPILE_ENVIRONMENT -INSTALL_TARGETS += xpcshell-updater -xpcshell-updater_TARGET := libs -xpcshell-updater_DEST := $(XPCSHELLTESTROOT)/data -xpcshell-updater_FILES := $(DIST)/bin/updater-xpcshell$(BIN_SUFFIX) -endif -endif # Not MOZ_PROFILE_GENERATE - include $(topsrcdir)/config/rules.mk ifndef MOZ_WINCONSOLE ifdef MOZ_DEBUG MOZ_WINCONSOLE = 1 else MOZ_WINCONSOLE = 0 endif endif -ifdef MOZ_WIDGET_GTK -libs:: ../updater.png - $(NSINSTALL) -D $(DIST)/bin/icons - $(INSTALL) $(IFLAGS1) $^ $(DIST)/bin/icons -endif - libs:: ifeq (cocoa,$(MOZ_WIDGET_TOOLKIT)) # Copy for xpcshell tests $(NSINSTALL) -D $(XPCSHELLTESTROOT)/data/updater-xpcshell.app rsync -a -C --exclude '*.in' $(srcdir)/../macbuild/Contents $(XPCSHELLTESTROOT)/data/updater-xpcshell.app sed -e 's/%APP_NAME%/$(MOZ_APP_DISPLAYNAME)/' $(srcdir)/../macbuild/Contents/Resources/English.lproj/InfoPlist.strings.in | \ iconv -f UTF-8 -t UTF-16 > $(XPCSHELLTESTROOT)/data/updater-xpcshell.app/Contents/Resources/English.lproj/InfoPlist.strings $(NSINSTALL) -D $(XPCSHELLTESTROOT)/data/updater-xpcshell.app/Contents/MacOS/updater-xpcshell - $(NSINSTALL) $(XPCSHELLTESTROOT)/data/updater-xpcshell $(XPCSHELLTESTROOT)/data/updater-xpcshell.app/Contents/MacOS - rm -f $(XPCSHELLTESTROOT)/data/updater-xpcshell + $(NSINSTALL) $(PROGRAM) $(XPCSHELLTESTROOT)/data/updater-xpcshell.app/Contents/MacOS + rm -f $(PROGRAM) rm -Rf $(XPCSHELLTESTROOT)/data/updater.app mv $(XPCSHELLTESTROOT)/data/updater-xpcshell.app $(XPCSHELLTESTROOT)/data/updater.app mv $(XPCSHELLTESTROOT)/data/updater.app/Contents/MacOS/updater-xpcshell $(XPCSHELLTESTROOT)/data/updater.app/Contents/MacOS/updater # Copy for mochitest chrome tests rsync -a -C $(XPCSHELLTESTROOT)/data/updater.app $(MOCHITESTROOT)/data/updater.app else - mv $(XPCSHELLTESTROOT)/data/updater-xpcshell$(BIN_SUFFIX) $(XPCSHELLTESTROOT)/data/updater$(BIN_SUFFIX) + mv $(PROGRAM) $(XPCSHELLTESTROOT)/data/updater$(BIN_SUFFIX) cp $(XPCSHELLTESTROOT)/data/updater$(BIN_SUFFIX) $(MOCHITESTROOT)/data/updater$(BIN_SUFFIX) endif CXXFLAGS += $(MOZ_BZ2_CFLAGS)
--- a/toolkit/mozapps/update/updater/updater-xpcshell/moz.build +++ b/toolkit/mozapps/update/updater/updater-xpcshell/moz.build @@ -2,10 +2,11 @@ # vim: set filetype=python: # This Source Code Form is subject to the terms of the Mozilla Public # License, v. 2.0. If a copy of the MPL was not distributed with this # file, You can obtain one at http://mozilla.org/MPL/2.0/. Program('updater-xpcshell') updater_rel_path = '../' +NO_DIST_INSTALL = True DEFINES['UPDATER_XPCSHELL_CERT'] = True include('../updater-common.build')