bug 1409622 initialize mTime even in Stream AudioTimelineEvents r=padenot
authorKarl Tomlinson <karlt+@karlt.net>
Tue, 07 Nov 2017 13:14:22 +1300
changeset 390607 1924564466fe274a20ce6c15a97e5f106cb9a3a9
parent 390606 140a38df3d5639e8a15e2cb5f2fd35d844e44d67
child 390608 48d145c66364885612e62a6aeefd048d2fc11952
push id32838
push usernbeleuzu@mozilla.com
push dateWed, 08 Nov 2017 10:46:55 +0000
treeherdermozilla-central@3e95c596ad5b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs1409622
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
bug 1409622 initialize mTime even in Stream AudioTimelineEvents r=padenot to avoid uninitialized read in WebAudioUtils::ConvertAudioTimelineEventToTicks() MozReview-Commit-ID: GHPGIrc0T2h
dom/media/webaudio/AudioEventTimeline.cpp
--- a/dom/media/webaudio/AudioEventTimeline.cpp
+++ b/dom/media/webaudio/AudioEventTimeline.cpp
@@ -80,16 +80,17 @@ AudioTimelineEvent::AudioTimelineEvent(M
   : mType(Stream)
   , mCurve(nullptr)
   , mStream(aStream)
   , mTimeConstant(0.0)
   , mDuration(0.0)
 #ifdef DEBUG
   , mTimeIsInTicks(false)
 #endif
+  , mTime(0.0)
 {
 }
 
 AudioTimelineEvent::AudioTimelineEvent(const AudioTimelineEvent& rhs)
 {
   PodCopy(this, &rhs, 1);
 
   if (rhs.mType == AudioTimelineEvent::SetValueCurve) {