Bug 1544961 - comment on gtests that are disabled, disable ThreadUtils.IdleRunnableMethod and Timers.FindExpirationTime for windows10-aarch64 r=jmaher,gbrown,dmajor
authorEdwin Gao <egao@mozilla.com>
Tue, 23 Apr 2019 00:21:37 +0000
changeset 470427 181f8519792032d158f03d2757724df99955cd44
parent 470426 09240f7397c12707cc0a8ff63051d28568be40e9
child 470428 f413cb36905d980cccb30577f827938f80cbe913
push id35905
push userdvarga@mozilla.com
push dateTue, 23 Apr 2019 09:53:27 +0000
treeherdermozilla-central@831918f009f6 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjmaher, gbrown, dmajor
bugs1544961
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1544961 - comment on gtests that are disabled, disable ThreadUtils.IdleRunnableMethod and Timers.FindExpirationTime for windows10-aarch64 r=jmaher,gbrown,dmajor Changes: - added comments for tests being disabled - disabled two additional tests in order to green the run Differential Revision: https://phabricator.services.mozilla.com/D28085
dom/media/doctor/gtest/TestMultiWriterQueue.cpp
gfx/tests/gtest/moz.build
image/test/gtest/moz.build
intl/gtest/moz.build
memory/gtest/moz.build
xpcom/tests/gtest/moz.build
--- a/dom/media/doctor/gtest/TestMultiWriterQueue.cpp
+++ b/dom/media/doctor/gtest/TestMultiWriterQueue.cpp
@@ -151,16 +151,18 @@ static void TestMultiWriterQueueMT(int a
       "alloc=%d (w %d)\n",
       aPrintPrefix, aWriterThreads, aReaderThreads, loops, pushes, duration,
       pushes / duration, q.LiveBuffersStats().mCount,
       q.LiveBuffersStats().mWatermark, q.ReusableBuffersStats().mCount,
       q.ReusableBuffersStats().mWatermark, q.AllocatedBuffersStats().mCount,
       q.AllocatedBuffersStats().mWatermark);
 }
 
+// skip test on windows10-aarch64 due to unexpected test timeout at
+// MultiWriterSingleReader, bug 1526001
 #if !defined(_M_ARM64)
 TEST(MultiWriterQueue, MultiWriterSingleReader)
 {
   // Small BufferSize, to exercize the buffer management code.
   TestMultiWriterQueueMT<
       MultiWriterQueue<int, 10, MultiWriterQueueReaderLocking_None>>(
       1, 0, 2 * 1024 * 1024, "MultiWriterQueue<int, 10, Locking_None>");
   TestMultiWriterQueueMT<
@@ -213,16 +215,18 @@ TEST(MultiWriterQueue, MultiWriterSingle
   // DEBUG-mode thread-safety checks should make the following (multi-reader
   // with no locking) crash; uncomment to verify.
   // TestMultiWriterQueueMT<
   //   MultiWriterQueue<int, MultiWriterQueueDefaultBufferSize,
   //   MultiWriterQueueReaderLocking_None>>(64, 2, 2*1024*1024);
 }
 #endif
 
+// skip test on windows10-aarch64 due to unexpected test timeout at
+// MultiWriterMultiReade, bug 1526001
 #if !defined(_M_ARM64)
 TEST(MultiWriterQueue, MultiWriterMultiReader)
 {
   static_assert(
       mozilla::IsSame<MultiWriterQueue<int, 10>,
                       MultiWriterQueue<
                           int, 10, MultiWriterQueueReaderLocking_Mutex>>::value,
       "MultiWriterQueue reader locking should use Mutex by default");
--- a/gfx/tests/gtest/moz.build
+++ b/gfx/tests/gtest/moz.build
@@ -21,17 +21,17 @@ UNIFIED_SOURCES += [
     'TestQcms.cpp',
     'TestRegion.cpp',
     'TestSkipChars.cpp',
     'TestSwizzle.cpp',
     'TestTextures.cpp',
     'TestTreeTraversal.cpp',
 ]
 
-# skip the test on windows10-aarch64
+# skip the test on windows10-aarch64 due to perma-crash - bug 1544961
 if not(CONFIG['OS_TARGET'] == 'WINNT' and CONFIG['CPU_ARCH'] == 'aarch64'):
     UNIFIED_SOURCES += [
         'TestVsync.cpp',
     ]
 
 if CONFIG['OS_TARGET'] != 'Android':
     UNIFIED_SOURCES += [
         'TestCompositor.cpp',
--- a/image/test/gtest/moz.build
+++ b/image/test/gtest/moz.build
@@ -20,17 +20,17 @@ UNIFIED_SOURCES = [
 ]
 
 if CONFIG['OS_TARGET'] != 'Android':
     UNIFIED_SOURCES += [
         'TestContainers.cpp',
         'TestFrameAnimator.cpp',
     ]
 
-# skip the test on windows10-aarch64 and Android
+# skip the test on windows10-aarch64 and Android, aarch64 due to 1544961
 if not(CONFIG['OS_TARGET'] == 'WINNT' and CONFIG['CPU_ARCH'] == 'aarch64') and (CONFIG['OS_TARGET'] != 'Android'):
     UNIFIED_SOURCES += [
         'TestDecoders.cpp',
         'TestDecodeToSurface.cpp',
         'TestMetadata.cpp',
         'TestSourceBuffer.cpp',
         'TestSurfaceCache.cpp',
     ]
--- a/intl/gtest/moz.build
+++ b/intl/gtest/moz.build
@@ -1,14 +1,15 @@
 # -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
 UNIFIED_SOURCES += []
 
+# skip the test on windows10-aarch64 due to perma-crash - bug 1544961
 if not(CONFIG['OS_TARGET'] == 'WINNT' and CONFIG['CPU_ARCH'] == 'aarch64'):
     UNIFIED_SOURCES += [
         'TestEncoding.cpp'
     ]
 
 FINAL_LIBRARY = 'xul-gtest'
--- a/memory/gtest/moz.build
+++ b/memory/gtest/moz.build
@@ -1,14 +1,15 @@
 # -*- Mode: python; indent-tabs-mode: nil; tab-width: 40 -*-
 # vim: set filetype=python:
 # This Source Code Form is subject to the terms of the Mozilla Public
 # License, v. 2.0. If a copy of the MPL was not distributed with this
 # file, You can obtain one at http://mozilla.org/MPL/2.0/.
 
+# skip the test on windows10-aarch64 due to perma-crash - bug 1544961
 if CONFIG['OS_TARGET'] != 'Android' and not(CONFIG['OS_TARGET'] == 'WINNT' and CONFIG['CPU_ARCH'] == 'aarch64'):
     UNIFIED_SOURCES += [
         'TestJemalloc.cpp',
     ]
 
 FINAL_LIBRARY = 'xul-gtest'
 
 LOCAL_INCLUDES += [
--- a/xpcom/tests/gtest/moz.build
+++ b/xpcom/tests/gtest/moz.build
@@ -48,33 +48,44 @@ UNIFIED_SOURCES += [
     'TestTArray.cpp',
     'TestTArray2.cpp',
     'TestTaskQueue.cpp',
     'TestTextFormatter.cpp',
     'TestThreadManager.cpp',
     'TestThreadMetrics.cpp',
     'TestThreadPool.cpp',
     'TestThreadPoolListener.cpp',
-    'TestThreadUtils.cpp',
     'TestThrottledEventQueue.cpp',
     'TestTimeStamp.cpp',
     'TestTokenizer.cpp',
     'TestUTF.cpp',
 ]
 
 if CONFIG['OS_TARGET'] != 'Android':
     UNIFIED_SOURCES += [
         'TestAtoms.cpp',
         'TestBase64.cpp',
         'TestPipes.cpp',
         'TestStrings.cpp',
         'TestThreads.cpp',
-        'TestTimers.cpp',
+    ]
+
+# skip the test on windows10-aarch64 due to perma-fail, bug 1422219
+if not(CONFIG['OS_TARGET'] == 'WINNT' and CONFIG['CPU_ARCH'] == 'aarch64'):
+    UNIFIED_SOURCES += [
+        'TestThreadUtils.cpp'
     ]
 
+# skip the test on windows10-aarch64 and Android, aarch64 due to bug 1545670
+if CONFIG['OS_TARGET'] != 'Android' and not(CONFIG['OS_TARGET'] == 'WINNT' and CONFIG['CPU_ARCH'] == 'aarch64'):
+    UNIFIED_SOURCES += [
+        'TestTimers.cpp'
+    ]
+
+
 if CONFIG['MOZ_DEBUG'] and CONFIG['OS_ARCH'] not in ('WINNT') and CONFIG['OS_TARGET'] != 'Android':
     # FIXME bug 523392: TestDeadlockDetector doesn't like Windows
     # Bug 1054249: Doesn't work on Android
     UNIFIED_SOURCES += [
         'TestDeadlockDetector.cpp',
         'TestDeadlockDetectorScalability.cpp',
     ]