Bug 1219079 - Small breakdown-related fixes for the memory tool; r=jsantell
☠☠ backed out by f680104e1145 ☠ ☠
authorNick Fitzgerald <fitzgen@gmail.com>
Wed, 28 Oct 2015 02:11:06 -0700
changeset 269936 167cd2f19d9368498359f528df23acde21fc5b16
parent 269935 2e2f56672850b6f218e31ac80774b0d1d008bb16
child 269937 604e693761bdc5c28f11afad54674f3856e7f518
push id29595
push userkwierso@gmail.com
push dateWed, 28 Oct 2015 23:41:46 +0000
treeherdermozilla-central@769f29c92bb2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjsantell
bugs1219079
milestone44.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1219079 - Small breakdown-related fixes for the memory tool; r=jsantell * Add "Breakdown by" in front of dropdown selector for the selected breakdown. * "Allocation Site" => "Allocation Stack" for breakdown's label. * Make the coarse type breakdown bucket strings by count.
devtools/client/memory/components/toolbar.js
devtools/client/memory/constants.js
--- a/devtools/client/memory/components/toolbar.js
+++ b/devtools/client/memory/components/toolbar.js
@@ -31,20 +31,23 @@ const Toolbar = module.exports = createC
       onToggleInverted,
       inverted
     } = this.props;
 
     return (
       DOM.div({ className: "devtools-toolbar" }, [
         DOM.button({ className: `take-snapshot devtools-button`, onClick: onTakeSnapshotClick }),
 
-        DOM.select({
-          className: `select-breakdown`,
-          onChange: e => onBreakdownChange(e.target.value),
-        }, breakdowns.map(({ name, displayName }) => DOM.option({ value: name }, displayName))),
+        DOM.label({},
+          "Breakdown by ",
+          DOM.select({
+            className: `select-breakdown`,
+            onChange: e => onBreakdownChange(e.target.value),
+          }, breakdowns.map(({ name, displayName }) => DOM.option({ value: name }, displayName)))
+        ),
 
         DOM.label({}, [
           DOM.input({
             type: "checkbox",
             checked: inverted,
             onChange: onToggleInverted,
           }),
           // TODO bug 1214799
--- a/devtools/client/memory/constants.js
+++ b/devtools/client/memory/constants.js
@@ -47,24 +47,24 @@ const ALLOCATION_STACK = { by: "allocati
 const OBJECT_CLASS = { by: "objectClass", then: COUNT, other: COUNT };
 
 const breakdowns = exports.breakdowns = {
   coarseType: {
     displayName: "Coarse Type",
     breakdown: {
       by: "coarseType",
       objects: ALLOCATION_STACK,
-      strings: ALLOCATION_STACK,
+      strings: COUNT,
       scripts: INTERNAL_TYPE,
       other: INTERNAL_TYPE,
     }
   },
 
   allocationStack: {
-    displayName: "Allocation Site",
+    displayName: "Allocation Stack",
     breakdown: ALLOCATION_STACK,
   },
 
   objectClass: {
     displayName: "Object Class",
     breakdown: OBJECT_CLASS,
   },