Bug 1469423 - add an option to let l10n-bumper trigger builds. r=mtabara
authorJulien Cristau <jcristau@mozilla.com>
Tue, 19 Jun 2018 17:24:05 +0200
changeset 423962 166bb5e000047989e2aa8f3553dfc39adf318201
parent 423961 e52c11b8f8ec6e7a88430aabb187f886e88df509
child 423963 4b0113139f3dfc004077edefc83b3187f605e0e5
push id34197
push usercsabou@mozilla.com
push dateThu, 28 Jun 2018 09:44:02 +0000
treeherdermozilla-central@db455160668d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmtabara
bugs1469423
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1469423 - add an option to let l10n-bumper trigger builds. r=mtabara MozReview-Commit-ID: CYOHmQ4os8l
testing/mozharness/scripts/l10n_bumper.py
--- a/testing/mozharness/scripts/l10n_bumper.py
+++ b/testing/mozharness/scripts/l10n_bumper.py
@@ -35,16 +35,24 @@ class L10nBumper(VCSScript):
     config_options = [[
         ['--ignore-closed-tree', ],
         {
             "action": "store_true",
             "dest": "ignore_closed_tree",
             "default": False,
             "help": "Bump l10n changesets on a closed tree."
         }
+    ], [
+        ['--build', ],
+        {
+            "action": "store_false",
+            "dest": "dontbuild",
+            "default": True,
+            "help": "Trigger new builds on push."
+        }
     ]]
 
     def __init__(self, require_config_file=True):
         super(L10nBumper, self).__init__(
             all_actions=[
                 'clobber',
                 'check-treestatus',
                 'checkout-gecko',
@@ -186,19 +194,21 @@ class L10nBumper(VCSScript):
             for k, v in platform_dict.items():
                 v['revision'] = 'default'
                 revision_dict[k] = v
         self.info("revision_dict:\n%s" % pprint.pformat(revision_dict))
         return revision_dict
 
     def build_commit_message(self, name, locale_map):
         comments = ''
-        approval_str = 'DONTBUILD r=release a=l10n-bump'
+        approval_str = 'r=release a=l10n-bump'
         for locale, revision in sorted(locale_map.items()):
             comments += "%s -> %s\n" % (locale, revision)
+        if self.config['dontbuild']:
+            approval_str += " DONTBUILD"
         if self.config['ignore_closed_tree']:
             approval_str += " CLOSED TREE"
         message = 'no bug - Bumping %s %s\n\n' % (name, approval_str)
         message += comments
         message = message.encode("utf-8")
         return message
 
     def query_treestatus(self):