Bug 1506884 - Document thread usage of mRtpPacketQueue in VideoConduit; r=padenot
☠☠ backed out by a0084ecbf671 ☠ ☠
authorDan Minor <dminor@mozilla.com>
Wed, 27 Mar 2019 16:54:38 +0000
changeset 466401 1584d9804aa189196f47e504f27c3a133fca2d47
parent 466400 409294d60d619331bc1bc5090cc93933b686595c
child 466402 5837db3740b54ff6e34d90ee0da41fe909022e06
push id35768
push useropoprus@mozilla.com
push dateThu, 28 Mar 2019 09:55:54 +0000
treeherdermozilla-central@c045dd97faf2 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspadenot
bugs1506884
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1506884 - Document thread usage of mRtpPacketQueue in VideoConduit; r=padenot This was added during the branch 64 update, but was not documented at that time. Differential Revision: https://phabricator.services.mozilla.com/D25054
media/webrtc/signaling/src/media-conduit/VideoConduit.h
--- a/media/webrtc/signaling/src/media-conduit/VideoConduit.h
+++ b/media/webrtc/signaling/src/media-conduit/VideoConduit.h
@@ -586,16 +586,17 @@ class WebrtcVideoConduit
 
   // Accessed only on mStsThread.
   bool mWaitingForInitialSsrc = true;
 
   // Accessed during configuration/signaling (main),
   // and when receiving packets (sts).
   Atomic<uint32_t> mRecvSSRC;  // this can change during a stream!
 
+  // Accessed only on mStsThread.
   RtpPacketQueue mRtpPacketQueue;
 
   // The lifetime of these codecs are maintained by the VideoConduit instance.
   // They are passed to the webrtc::VideoSendStream or VideoReceiveStream,
   // on construction.
   std::unique_ptr<webrtc::VideoEncoder> mEncoder;  // only one encoder for now
   std::vector<std::unique_ptr<webrtc::VideoDecoder>> mDecoders;
   // Main thread only