Bug 1511285 - followup: Properly wait for the child process. r+a=Andi
authorEmilio Cobos Álvarez <emilio@crisal.io>
Fri, 30 Nov 2018 19:01:38 +0100
changeset 448951 138f65958545ae296c6742b9a13ca83f8310a0d8
parent 448950 bf92aff5b93de1726b12207adc54dd138178250d
child 448952 bb2815518fc776afaf5e54a3fb4c9d2c5e66ed0e
push id35135
push useremilio@crisal.io
push dateFri, 30 Nov 2018 18:13:31 +0000
treeherdermozilla-central@138f65958545 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
bugs1511285
milestone65.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1511285 - followup: Properly wait for the child process. r+a=Andi
python/mozbuild/mozbuild/mach_commands.py
--- a/python/mozbuild/mozbuild/mach_commands.py
+++ b/python/mozbuild/mozbuild/mach_commands.py
@@ -2822,16 +2822,17 @@ class StaticAnalysis(MachCommandBase):
         # the .clang-format when it is ran outside of the repo, for example
         # by the extension hg-formatsource
         args = [clang_format, "-assume-filename={}".format(assume_filename[0])]
 
         process = subprocess.Popen(args, stdin=subprocess.PIPE)
         with open(paths[0], 'r') as fin:
             process.stdin.write(fin.read())
             process.stdin.close()
+            process.wait();
             return 0
 
     def _run_clang_format_path(self, clang_format, show, paths):
         # Run clang-format on files or directories directly
         from subprocess import check_output, CalledProcessError
 
         args = [clang_format, "-i"]