Bug 1634012 - Remove the browser.tabs.showAudioPlayingIcon pref.r=dao
authorjayati <gaurijove@gmail.com>
Wed, 29 Apr 2020 17:22:48 +0000
changeset 526720 1360dbbd2d6d1c65543e1b868211c93d66f55963
parent 526719 02ec29a89e9db3c5a0736c736d05dc3488ed62a9
child 526721 1186bfb95124b562ce026f8f8667d3ed35d30e5b
push id37361
push usermalexandru@mozilla.com
push dateWed, 29 Apr 2020 21:55:39 +0000
treeherdermozilla-central@bc0932b38478 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1634012
milestone77.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1634012 - Remove the browser.tabs.showAudioPlayingIcon pref.r=dao Differential Revision: https://phabricator.services.mozilla.com/D73084
browser/app/profile/firefox.js
browser/base/content/tabbrowser.js
browser/base/content/test/tabs/browser_audioTabIcon.js
mobile/android/app/mobile.js
--- a/browser/app/profile/firefox.js
+++ b/browser/app/profile/firefox.js
@@ -471,17 +471,16 @@ pref("browser.tabs.extraDragSpace", fals
 
 // When tabs opened by links in other tabs via a combination of
 // browser.link.open_newwindow being set to 3 and target="_blank" etc are
 // closed:
 // true   return to the tab that opened this tab (its owner)
 // false  return to the adjacent tab (old default)
 pref("browser.tabs.selectOwnerOnClose", true);
 
-pref("browser.tabs.showAudioPlayingIcon", true);
 // This should match Chromium's audio indicator delay.
 pref("browser.tabs.delayHidingAudioPlayingIconMS", 3000);
 
 // Pref to control whether we use a separate privileged content process
 // for about: pages. This pref name did not age well: we will have multiple
 // types of privileged content processes, each with different privileges.
 // types of privleged content processes, each with different privleges.
 #if defined(MOZ_CODE_COVERAGE) && defined(XP_LINUX) || defined(MOZ_ASAN)
--- a/browser/base/content/tabbrowser.js
+++ b/browser/base/content/tabbrowser.js
@@ -787,20 +787,17 @@
       let browser = aBrowser || this.selectedBrowser;
       if (!browser.tabModalPromptBox) {
         browser.tabModalPromptBox = new TabModalPromptBox(browser);
       }
       return browser.tabModalPromptBox;
     },
 
     getTabFromAudioEvent(aEvent) {
-      if (
-        !Services.prefs.getBoolPref("browser.tabs.showAudioPlayingIcon") ||
-        !aEvent.isTrusted
-      ) {
+      if (!aEvent.isTrusted) {
         return null;
       }
 
       var browser = aEvent.originalTarget;
       var tab = this.getTabForBrowser(browser);
       return tab;
     },
 
--- a/browser/base/content/test/tabs/browser_audioTabIcon.js
+++ b/browser/base/content/test/tabs/browser_audioTabIcon.js
@@ -645,22 +645,16 @@ async function test_delayed_tabattr_remo
     {
       gBrowser,
       url: PAGE,
     },
     taskFn
   );
 }
 
-add_task(async function() {
-  await SpecialPowers.pushPrefEnv({
-    set: [["browser.tabs.showAudioPlayingIcon", true]],
-  });
-});
-
 requestLongerTimeout(2);
 add_task(async function test_page() {
   await BrowserTestUtils.withNewTab(
     {
       gBrowser,
       url: PAGE,
     },
     test_on_browser
--- a/mobile/android/app/mobile.js
+++ b/mobile/android/app/mobile.js
@@ -671,18 +671,16 @@ pref("layout.accessiblecaret.script_chan
 
 // Optionally provide haptic feedback on longPress selection events.
 pref("layout.accessiblecaret.hapticfeedback", true);
 
 // Initial text selection on long-press is enhanced to provide
 // a smarter phone-number selection for direct-dial ActionBar action.
 pref("layout.accessiblecaret.extend_selection_for_phone_number", true);
 
-pref("browser.tabs.showAudioPlayingIcon", true);
-
 pref("dom.serviceWorkers.enabled", true);
 
 // Allow service workers to open windows for a longer period after a notification
 // click on mobile.  This is to account for some devices being quite slow.
 pref("dom.serviceWorkers.disable_open_click_delay", 5000);
 
 pref("dom.push.debug", false);
 pref("dom.push.maxRecentMessageIDsPerSubscription", 0);