Bug 1287492 - (followup) Rename GetNearestSVGParent backto GetNearestSVGViewport. r=me
authorcku <cku@mozilla.com>
Tue, 14 Feb 2017 23:19:58 +0800
changeset 342818 1330b7dba04a5d57febb68ddcd769676db8ba450
parent 342817 588005db93d516de7e6f35ff54b9f5c4f4ec97bd
child 342819 b3404ec6a4f088b2244ff4c67780f6f792f631b2
push id31363
push userkwierso@gmail.com
push dateTue, 14 Feb 2017 21:12:30 +0000
treeherdermozilla-central@1060668405a9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs1287492
milestone54.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1287492 - (followup) Rename GetNearestSVGParent backto GetNearestSVGViewport. r=me According to jwatt's suggestion, rename back to original name. MozReview-Commit-ID: 8dUo7ZWoac6
layout/svg/nsFilterInstance.cpp
layout/svg/nsSVGUtils.cpp
layout/svg/nsSVGUtils.h
--- a/layout/svg/nsFilterInstance.cpp
+++ b/layout/svg/nsFilterInstance.cpp
@@ -244,17 +244,17 @@ nsFilterInstance::ComputeTargetBBoxInFil
     return true;
   }
 
   // SVG graphic elements will always be clipped by svg::svg element, so we
   // should clip mTargetBBoxInFilterSpace by the bounded parent SVG frame
   // anyway to shrink the size of surface that we are going to create later in
   // BuildSourcePaint and BuildSourceImage.
   MOZ_ASSERT(mTargetFrame->IsFrameOfType(nsIFrame::eSVG));
-  nsIFrame* svgFrame = nsSVGUtils::GetNearestSVGParent(mTargetFrame);
+  nsIFrame* svgFrame = nsSVGUtils::GetNearestSVGViewport(mTargetFrame);
   if (svgFrame) {
     nscoord A2D = svgFrame->PresContext()->AppUnitsPerCSSPixel();
     nsIntRect bounds =
       svgFrame->GetVisualOverflowRect().ToOutsidePixels(A2D);
 
     mTargetBBoxInFilterSpace = mTargetBBoxInFilterSpace.Intersect(bounds);
   }
 
--- a/layout/svg/nsSVGUtils.cpp
+++ b/layout/svg/nsSVGUtils.cpp
@@ -144,17 +144,17 @@ nsSVGUtils::Init()
   Preferences::AddBoolVarCache(&sSVGDisplayListPaintingEnabled,
                                "svg.display-lists.painting.enabled");
 
   Preferences::AddBoolVarCache(&sSVGNewGetBBoxEnabled,
                                "svg.new-getBBox.enabled");
 }
 
 nsIFrame*
-nsSVGUtils::GetNearestSVGParent(nsIFrame *aFrame)
+nsSVGUtils::GetNearestSVGViewport(nsIFrame *aFrame)
 {
   NS_ASSERTION(aFrame->IsFrameOfType(nsIFrame::eSVG), "SVG frame expected");
 
   for (; aFrame &&  aFrame->IsFrameOfType(nsIFrame::eSVG);
        aFrame = aFrame->GetParent()) {
     NS_ASSERTION(aFrame->IsFrameOfType(nsIFrame::eSVG), "SVG frame expected");
     if (aFrame->GetType() == nsGkAtoms::svgInnerSVGFrame ||
         aFrame->GetType() == nsGkAtoms::svgOuterSVGFrame) {
--- a/layout/svg/nsSVGUtils.h
+++ b/layout/svg/nsSVGUtils.h
@@ -193,17 +193,17 @@ public:
   static void Init();
 
   NS_DECLARE_FRAME_PROPERTY_DELETABLE(ObjectBoundingBoxProperty, gfxRect)
 
   /**
    * Gets the nearest nsSVGInnerSVGFrame or nsSVGOuterSVGFrame frame. aFrame
    * must be an SVG frame.
    */
-  static nsIFrame* GetNearestSVGParent(nsIFrame *aFrame);
+  static nsIFrame* GetNearestSVGViewport(nsIFrame *aFrame);
 
   /**
    * Returns the frame's post-filter visual overflow rect when passed the
    * frame's pre-filter visual overflow rect. If the frame is not currently
    * being filtered, this function simply returns aUnfilteredRect.
    */
   static nsRect GetPostFilterVisualOverflowRect(nsIFrame *aFrame,
                                                 const nsRect &aUnfilteredRect);