Backed out changeset 15e19c4203af (bug 1703957) for causing issues with addressbar suggestions (Bug 1707257). a=backout
authorAlexandru Michis <malexandru@mozilla.com>
Fri, 23 Apr 2021 22:57:45 +0300
changeset 577164 1241823043e92c9915ed7cae9e71361c652321f4
parent 577163 9b7bac5af873863628d90e89299a813228ddbb83
child 577183 5413cedf852d89586c2935cd9c59ec7bad12cd05
push id38401
push usermalexandru@mozilla.com
push dateFri, 23 Apr 2021 19:58:49 +0000
treeherdermozilla-central@1241823043e9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbackout
bugs1703957, 1707257
milestone90.0a1
backs out15e19c4203af1494bea1b304c4b723bf24769f0e
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Backed out changeset 15e19c4203af (bug 1703957) for causing issues with addressbar suggestions (Bug 1707257). a=backout
browser/themes/addons/dark/manifest.json
browser/themes/addons/light/manifest.json
browser/themes/osx/browser.css
browser/themes/shared/browser-custom-colors.inc.css
browser/themes/shared/urlbar-searchbar.inc.css
browser/themes/windows/browser.css
--- a/browser/themes/addons/dark/manifest.json
+++ b/browser/themes/addons/dark/manifest.json
@@ -91,17 +91,16 @@
       "checkbox_checked_background_hover": "--checkbox-checked-hover-bgcolor",
       "checkbox_checked_background_active": "--checkbox-checked-active-bgcolor",
       "error_text_color": "--error-text-color",
       "input_background": "--input-bgcolor",
       "input_color": "--input-color",
       "input_border": "--input-border-color",
       "input_border_error": "--input-error-border-color",
       "autocomplete_popup_separator": "--autocomplete-popup-separator-color",
-      "zoom_controls": "--zoom-controls-bgcolor",
       "appmenu_update_icon_color": "--panel-banner-item-update-supported-bgcolor",
       "appmenu_warning_icon_color": "--panel-banner-item-warning-icon-bgcolor",
       "appmenu_info_icon_color": "--panel-banner-item-info-icon-bgcolor"
     },
     "properties": {
       "panel_hover": "--arrowpanel-dimmed",
       "panel_active": "--arrowpanel-dimmed-further",
       "panel_active_darker": "--arrowpanel-dimmed-even-further"
--- a/browser/themes/addons/light/manifest.json
+++ b/browser/themes/addons/light/manifest.json
@@ -48,16 +48,19 @@
       "checkbox_border_color": "rgb(143, 143, 157)",
       "checkbox_unchecked_background": "rgb(240, 240, 244)",
       "checkbox_unchecked_background_hover": "rgb(224, 224, 230)",
       "checkbox_unchecked_background_active": "rgb(207, 207, 216)",
       "checkbox_checked_background": "rgb(0, 97, 224)",
       "checkbox_checked_background_hover": "rgb(2, 80, 187)",
       "checkbox_checked_background_active": "rgb(5, 62, 148)",
       "checkbox_checked_color": "rgb(251, 251, 254)",
+      "panel_hover": "rgb(224,224,230)",
+      "panel_active": "rgb(207,207,21)",
+      "panel_active_darker": "rgb(191,191,201)",
       "autocomplete_popup_hover": "rgb(240,240,244)",
       "autocomplete_popup_separator": "rgb(240,240,244)",
       "appmenu_update_icon_color": "#2AC3A2",
       "appmenu_warning_icon_color": "#FFA436",
       "appmenu_info_icon_color": "#0090ED"
     },
     "properties": {
       "panel_hover": "color-mix(in srgb, currentColor 12%, transparent)",
--- a/browser/themes/osx/browser.css
+++ b/browser/themes/osx/browser.css
@@ -3,16 +3,17 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 
 @namespace html url("http://www.w3.org/1999/xhtml");
 
 %include ../shared/browser.inc.css
 %include ../shared/browser-custom-colors.inc.css
 
 :root {
+  --toolbar-non-lwt-bgcolor: #f9f9fb;
   --toolbar-non-lwt-textcolor: #0c0c0d;
   --toolbar-non-lwt-bgimage: none;
 
   --toolbarbutton-vertical-text-padding: calc(var(--toolbarbutton-inner-padding) + 1px);
   --toolbarbutton-border-radius: 4px;
   --toolbarbutton-icon-fill-opacity: 1;
 
   --panel-separator-color: hsla(210,4%,10%,.14);
--- a/browser/themes/shared/browser-custom-colors.inc.css
+++ b/browser/themes/shared/browser-custom-colors.inc.css
@@ -40,28 +40,25 @@
     --input-bgcolor: rgb(255,255,255);
     --input-border-color: rgb(143,143,157);
     --input-error-border-color: #E22850;
 
     --tab-line-color: rgba(128,128,142,0.9);
     --tab-selected-bgcolor: rgb(255,255,255);
     --tabs-border-color: transparent;
     --toolbar-color: rgb(21,20,26);
-    --toolbar-non-lwt-bgcolor: #f9f9fb;
     --toolbarbutton-icon-fill: rgb(91,91,102);
 
     --urlbar-popup-action-color: rgb(21,20,26);
     --urlbar-popup-url-color: rgb(0,97,224);
 
     --autocomplete-popup-separator-color: rgb(240,240,244);
     --toolbar-field-border-color: transparent;
     --arrowpanel-border-color: transparent;
-    --chrome-content-separator-color: rgb(204,204,204);
 
     --toolbar-field-non-lwt-bgcolor: rgb(240,240,244);
-    --toolbar-field-non-lwt-color: rgb(21,20,26);
 
-    --autocomplete-popup-highlight-background: "#e0e0e6";
+    --autocomplete-popup-highlight-background: var(--arrowpanel-dimmed);
     --autocomplete-popup-highlight-color: rgb(21,20,26);
     --autocomplete-popup-hover-background: rgb(240,240,244);
   }
   } /** END Proton **/
 }
--- a/browser/themes/shared/urlbar-searchbar.inc.css
+++ b/browser/themes/shared/urlbar-searchbar.inc.css
@@ -45,17 +45,17 @@
   padding-block: 5px;
 }
 }
 
 #urlbar,
 #searchbar {
   min-height: var(--urlbar-min-height);
   text-shadow: none;
-  color: var(--toolbar-field-non-lwt-color, FieldText);
+  color: FieldText;
 }
 
 @media not (-moz-proton) {
 #urlbar-container,
 #search-container {
   padding-block: 3px;
 }
 } /* END !proton */
--- a/browser/themes/windows/browser.css
+++ b/browser/themes/windows/browser.css
@@ -35,16 +35,17 @@
 @media not (-moz-proton) {
 #tabbrowser-tabs {
   --tab-line-color: highlight;
 }
 } /* end !proton */
 
 @media (-moz-windows-default-theme) {
   :root {
+    --toolbar-non-lwt-bgcolor: #f9f9fa;
     --toolbar-non-lwt-textcolor: #0c0c0d;
     --toolbar-non-lwt-bgimage: none;
 
     --panel-separator-color: hsla(210,4%,10%,.14);
 
     --chrome-content-separator-color: #e1e1e2;
   }