author | Michael Comella <michael.l.comella@gmail.com> |
Wed, 08 Jan 2014 14:11:58 -0800 | |
changeset 162633 | 1199a2ef815bf2b7c809c76b05f0737458ecdfe6 |
parent 162632 | fd040290d0440cd7d9197fb41f091be8cd2ff99d |
child 162634 | ac385aa66e484637fa4f88c1bdda3527d7af1221 |
push id | 25964 |
push user | kwierso@gmail.com |
push date | Thu, 09 Jan 2014 01:30:30 +0000 |
treeherder | mozilla-central@711f08b0aa1d [default view] [failures only] |
perfherder | [talos] [build metrics] [platform microbench] (compared to previous push) |
reviewers | wesj |
bugs | 956858 |
milestone | 29.0a1 |
first release with | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
last release without | nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
|
mobile/android/base/BrowserApp.java | file | annotate | diff | comparison | revisions | |
mobile/android/base/GeckoApp.java | file | annotate | diff | comparison | revisions |
--- a/mobile/android/base/BrowserApp.java +++ b/mobile/android/base/BrowserApp.java @@ -1847,17 +1847,17 @@ abstract public class BrowserApp extends } /** * Add the provided item to the provided menu, which should be * the root (mMenu). */ private void addAddonMenuItemToMenu(final Menu menu, final MenuItemInfo info) { info.added = true; - + final Menu destination; if (info.parent == 0) { destination = menu; } else if (info.parent == GECKO_TOOLS_MENU) { MenuItem tools = menu.findItem(R.id.tools); destination = tools != null ? tools.getSubMenu() : menu; } else { MenuItem parent = menu.findItem(info.parent); @@ -2011,18 +2011,21 @@ abstract public class BrowserApp extends share.setActionProvider(provider); } return true; } @Override public void openOptionsMenu() { - if (!hasTabsSideBar() && areTabsShown()) + // Disable menu access in edge cases only accessible to hardware menu buttons. + if ((!hasTabsSideBar() && areTabsShown()) || + mBrowserToolbar.isEditing()) { return; + } // Scroll custom menu to the top if (mMenuPanel != null) mMenuPanel.scrollTo(0, 0); if (!mBrowserToolbar.openOptionsMenu()) super.openOptionsMenu(); @@ -2471,17 +2474,17 @@ abstract public class BrowserApp extends } }).execute(); } // HomePager.OnNewTabsListener @Override public void onNewTabs(String[] urls) { final EnumSet<OnUrlOpenListener.Flags> flags = EnumSet.of(OnUrlOpenListener.Flags.ALLOW_SWITCH_TO_TAB); - + for (String url : urls) { if (!maybeSwitchToTab(url, flags)) { openUrlAndStopEditing(url, true); } } } // HomePager.OnUrlOpenListener
--- a/mobile/android/base/GeckoApp.java +++ b/mobile/android/base/GeckoApp.java @@ -393,17 +393,17 @@ public abstract class GeckoApp mMenuPanel = new MenuPanel(this, null); } else { // Prepare the panel everytime before showing the menu. onPreparePanel(featureId, mMenuPanel, mMenu); } return mMenuPanel; } - + return super.onCreatePanelView(featureId); } @Override public boolean onCreatePanelMenu(int featureId, Menu menu) { if (Build.VERSION.SDK_INT >= 11 && featureId == Window.FEATURE_OPTIONS_PANEL) { if (mMenuPanel == null) { mMenuPanel = (MenuPanel) onCreatePanelView(featureId);