Bug 1691577 - [devtools] Re-enable browser_toolbox_window_title_frame_select.js on fission. r=jdescottes.
authorNicolas Chevobbe <nchevobbe@mozilla.com>
Wed, 19 May 2021 16:58:05 +0000
changeset 580039 1001ace465707d88ac434f2e7f400dad59f29522
parent 580038 5212393f6266d8b8752b386826755840db0d127e
child 580040 6f9892cf815bcadcedfce0ccf4c8c2f175103c79
push id38476
push userdluca@mozilla.com
push dateWed, 19 May 2021 21:47:56 +0000
treeherdermozilla-central@1bbf4362b266 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjdescottes
bugs1691577
milestone90.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1691577 - [devtools] Re-enable browser_toolbox_window_title_frame_select.js on fission. r=jdescottes. This is fixed by the previous patches in this queue. Differential Revision: https://phabricator.services.mozilla.com/D115337
devtools/client/framework/test/browser.ini
devtools/client/framework/test/browser_toolbox_window_title_frame_select.js
--- a/devtools/client/framework/test/browser.ini
+++ b/devtools/client/framework/test/browser.ini
@@ -155,17 +155,16 @@ run-if = e10s
 [browser_toolbox_view_source_02.js]
 [browser_toolbox_view_source_03.js]
 [browser_toolbox_watchedByDevTools.js]
 [browser_toolbox_window_reload_target.js]
 [browser_toolbox_window_reload_target_force.js]
 [browser_toolbox_window_shortcuts.js]
 [browser_toolbox_window_title_changes.js]
 [browser_toolbox_window_title_frame_select.js]
-fail-if = fission
 [browser_toolbox_zoom.js]
 [browser_toolbox_zoom_popup.js]
 fail-if = a11y_checks # bug 1687737 tools-chevron-menu-button is not accessible
 [browser_two_tabs.js]
 [browser_webextension_descriptor.js]
 # We want these tests to run for mochitest-dt as well, so we include them here:
 [../../../../browser/base/content/test/static/browser_parsable_css.js]
 skip-if = debug || asan || (os == 'linux' && bits == 32) # no point in running on both opt and debug, and will likely intermittently timeout on debug
--- a/devtools/client/framework/test/browser_toolbox_window_title_frame_select.js
+++ b/devtools/client/framework/test/browser_toolbox_window_title_frame_select.js
@@ -76,27 +76,26 @@ add_task(async function() {
     b => b.querySelector(".label").textContent == IFRAME_URL
   )[0];
   ok(topFrameBtn, "Got top level document in the list");
   ok(iframeBtn, "Got iframe document in the list");
 
   // Listen to will-navigate to check if the view is empty
   const willNavigate = toolbox.target.once("will-navigate");
 
-  const onTitleChanged = waitForTitleChange(toolbox);
-
   // Only select the iframe after we are able to select an element from the top
   // level document.
   const onInspectorReloaded = toolbox.getPanel("inspector").once("reloaded");
   info("Select the iframe");
   iframeBtn.click();
 
   await willNavigate;
   await onInspectorReloaded;
-  await onTitleChanged;
+  // wait a bit more in case an eventual title update would happen later
+  await wait(1000);
 
   info("Navigation to the iframe is done, the inspector should be back up");
   is(
     getTitle(),
     `Developer Tools — Page title — ${URL}`,
     "Devtools title was not updated after changing inspected frame"
   );