No bug: Doc fix in js::jit::CanEnterBaselineAtBranch. DONTBUILD rs=jorendorff
authorJim Blandy <jimb@mozilla.com>
Mon, 15 Apr 2019 11:29:25 -0700
changeset 469601 0fd463c60290
parent 469600 a2b89a27e8eb
child 469602 a2a538f6c3c9
push id35875
push userccoroiu@mozilla.com
push dateTue, 16 Apr 2019 04:06:16 +0000
treeherdermozilla-central@a83cab75b00d [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersjorendorff
milestone68.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
No bug: Doc fix in js::jit::CanEnterBaselineAtBranch. DONTBUILD rs=jorendorff
js/src/jit/BaselineJIT.cpp
--- a/js/src/jit/BaselineJIT.cpp
+++ b/js/src/jit/BaselineJIT.cpp
@@ -276,19 +276,19 @@ MethodStatus jit::CanEnterBaselineAtBran
                                            InterpreterFrame* fp) {
   if (!CheckFrame(fp)) {
     return Method_CantCompile;
   }
 
   // This check is needed in the following corner case. Consider a function h,
   //
   //   function h(x) {
-  //      h(false);
   //      if (!x)
   //        return;
+  //      h(false);
   //      for (var i = 0; i < N; i++)
   //         /* do stuff */
   //   }
   //
   // Suppose h is not yet compiled in baseline and is executing in the
   // interpreter. Let this interpreter frame be f_older. The debugger marks
   // f_older as isDebuggee. At the point of the recursive call h(false), h is
   // compiled in baseline without debug instrumentation, pushing a baseline