Bug 1256535 - Disable C4577 to unblock compilation on VS2015; r=poiru
authorGregory Szorc <gps@mozilla.com>
Mon, 14 Mar 2016 21:44:22 -0700
changeset 288709 0ed826f3d2775d8d5eacb76fc39703db3670c622
parent 288708 97571d40a08ae5fb70b24195a50d7697c68c8f31
child 288710 024ce6807e881595694a78ae6c4213cee4a9cf94
push id30087
push usercbook@mozilla.com
push dateTue, 15 Mar 2016 09:43:43 +0000
treeherdermozilla-central@5e14887312d4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspoiru
bugs1256535
milestone48.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1256535 - Disable C4577 to unblock compilation on VS2015; r=poiru The previous disabling of this warning on just Key.cpp was not sufficient because another file from the unified sources list appears to include the header exhibiting the warning. MozReview-Commit-ID: rR2XXigTJU
dom/indexedDB/moz.build
--- a/dom/indexedDB/moz.build
+++ b/dom/indexedDB/moz.build
@@ -95,17 +95,17 @@ FINAL_LIBRARY = 'xul'
 
 if CONFIG['GNU_CC']:
     # Suppress gcc warning about a comparison being always false due to the
     # range of the data type
     SOURCES['Key.cpp'].flags += ['-Wno-error=type-limits']
 
 if CONFIG['_MSC_VER']:
     # This is intended as a temporary hack to support building with VS2015.
-    SOURCES['Key.cpp'].flags += ['-wd4577']
+    CXXFLAGS += ['-wd4577']
 
 LOCAL_INCLUDES += [
     '/db/sqlite3/src',
     '/dom/base',
     '/dom/storage',
     '/dom/workers',
     '/ipc/glue',
     '/xpcom/build',