Bug 851891. Make stringifier attributes fail to codegen. r=khuey
authorBoris Zbarsky <bzbarsky@mit.edu>
Tue, 14 Jan 2014 21:46:44 -0500
changeset 163445 0e1092eaa8671ece696c7b910bb812f4e6d18e21
parent 163444 4888ad4664d82680eeb2122c05c4e4b775714838
child 163446 d633e3ff201329c99a71bfc1311edc28a061cb99
push id25996
push useremorley@mozilla.com
push dateWed, 15 Jan 2014 15:54:39 +0000
treeherdermozilla-central@dd2cf81c56b7 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskhuey
bugs851891
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 851891. Make stringifier attributes fail to codegen. r=khuey
dom/bindings/Codegen.py
dom/webidl/URLUtils.webidl
--- a/dom/bindings/Codegen.py
+++ b/dom/bindings/Codegen.py
@@ -8684,16 +8684,20 @@ class CGDescriptor(CGThing):
                 elif descriptor.interface.hasInterfacePrototypeObject():
                     cgThings.append(CGSpecializedMethod(descriptor, m))
                     cgThings.append(CGMemberJITInfo(descriptor, m))
                     if m.getExtendedAttribute("CrossOriginCallable"):
                         crossOriginMethods.add(m.identifier.name)
                     else:
                         hasMethod = True
             elif m.isAttr():
+                if m.stringifier:
+                    raise TypeError("Stringifier attributes not supported yet. "
+                                    "See bug 824857.\n"
+                                    "%s" % m.location);
                 if m.isStatic():
                     assert descriptor.interface.hasInterfaceObject
                     cgThings.append(CGStaticGetter(descriptor, m))
                 elif descriptor.interface.hasInterfacePrototypeObject():
                     cgThings.append(CGSpecializedGetter(descriptor, m))
                     if m.hasLenientThis():
                         hasLenientGetter = True
                     elif m.getExtendedAttribute("CrossOriginReadable"):
--- a/dom/webidl/URLUtils.webidl
+++ b/dom/webidl/URLUtils.webidl
@@ -11,17 +11,19 @@
  * February 2013, the editors have made this specification available under
  * the Open Web Foundation Agreement Version 1.0, which is available at
  * http://www.openwebfoundation.org/legal/the-owf-1-0-agreements/owfa-1-0.
  */
 
 [NoInterfaceObject]
 interface URLUtils {
   [SetterThrows]
-  stringifier attribute DOMString href;
+  // Bug 824857: no support for stringifier attributes yet.
+  //  stringifier attribute DOMString href;
+           attribute DOMString href;
   readonly attribute DOMString origin;
 
            attribute DOMString protocol;
            attribute DOMString username;
            attribute DOMString password;
            attribute DOMString host;
            attribute DOMString hostname;
            attribute DOMString port;