Bug 1005755 - Update Net logging in the Console; r=nchevobbe
authorJan Odvarko <odvarko@gmail.com>
Mon, 16 Oct 2017 15:13:03 +0200
changeset 386399 0d8950ca188247d0f8634635d67e0989ced40036
parent 386398 00992de316f0b482c915de36337f3be0fc0c9730
child 386400 f22d51b93cf81f184d3d782429a5ca7bbb1925a4
push id32694
push userarchaeopteryx@coole-files.de
push dateTue, 17 Oct 2017 09:43:13 +0000
treeherdermozilla-central@3bd3448d9684 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnchevobbe
bugs1005755
milestone58.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1005755 - Update Net logging in the Console; r=nchevobbe MozReview-Commit-ID: 6lLjifqV2sQ
devtools/client/webconsole/new-console-output/components/message-types/NetworkEventMessage.js
--- a/devtools/client/webconsole/new-console-output/components/message-types/NetworkEventMessage.js
+++ b/devtools/client/webconsole/new-console-output/components/message-types/NetworkEventMessage.js
@@ -87,28 +87,45 @@ function NetworkEventMessage({
     }
   };
 
   // Message body components.
   const method = dom.span({className: "method" }, request.method);
   const xhr = isXHR
     ? dom.span({ className: "xhr" }, l10n.getStr("webConsoleXhrIndicator"))
     : null;
-  const url = dom.a({ className: "url", title: request.url, onClick: toggle },
+  const requestUrl = dom.a({ className: "url", title: request.url, onClick: toggle },
     request.url.replace(/\?.+/, ""));
   const statusBody = statusInfo
     ? dom.a({ className: "status", onClick: toggle }, statusInfo)
     : null;
 
-  const messageBody = [method, xhr, url, statusBody];
+  const messageBody = [method, xhr, requestUrl, statusBody];
+
+  // API consumed by Net monitor UI components. Most of the method
+  // are not needed in context of the Console panel (atm) and thus
+  // let's just provide empty implementation.
+  // Individual methods might be implemented step by step as needed.
+  let connector = {
+    viewSourceInDebugger: (url, line) => {
+      serviceContainer.onViewSourceInDebugger({url, line});
+    },
+    getLongString: () => {},
+    getTabTarget: () => {},
+    getNetworkRequest: () => {},
+    sendHTTPRequest: () => {},
+    setPreferences: () => {},
+    triggerActivity: () => {},
+  };
 
   // Only render the attachment if the network-event is
   // actually opened (performance optimization).
   const attachment = open && dom.div({className: "network-info devtools-monospace"},
     TabboxPanel({
+      connector,
       activeTabId: networkMessageActiveTabId,
       request: networkMessageUpdate,
       sourceMapService: serviceContainer.sourceMapService,
       openLink: serviceContainer.openLink,
       selectTab: (tabId) => {
         dispatch(actions.selectNetworkMessageTab(tabId));
       },
     })