Bug 1526769 - always initialize local_transform to the identity matrix r=nical
authorSam Rijs <srijs@airpost.net>
Mon, 11 Feb 2019 09:58:50 +0000
changeset 458471 0d65ca0a00195e03b4b7976d6bbbf5c5cb0c9d93
parent 458470 51d4957627fb25a8ec6ed9d43c6ea4c71ba0b6e9
child 458472 fed3acd909919697e5272b5be4ade16d12d5746f
push id35536
push userbtara@mozilla.com
push dateMon, 11 Feb 2019 21:54:04 +0000
treeherdermozilla-central@6d8e6f960446 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersnical
bugs1526769
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1526769 - always initialize local_transform to the identity matrix r=nical [wrupdater] From https://github.com/servo/webrender/pull/3547 Differential Revision: https://phabricator.services.mozilla.com/D19305
gfx/wr/webrender/res/ps_text_run.glsl
--- a/gfx/wr/webrender/res/ps_text_run.glsl
+++ b/gfx/wr/webrender/res/ps_text_run.glsl
@@ -66,17 +66,17 @@ VertexInfo write_text_vertex(RectWithSiz
                              Transform transform,
                              PictureTask task,
                              vec2 text_offset,
                              vec2 glyph_offset,
                              RectWithSize glyph_rect,
                              vec2 snap_bias) {
     // The offset to snap the glyph rect to a device pixel
     vec2 snap_offset = vec2(0.0);
-    mat2 local_transform;
+    mat2 local_transform = mat2(1.0);
 
 #ifdef WR_FEATURE_GLYPH_TRANSFORM
     bool remove_subpx_offset = true;
 #else
     bool remove_subpx_offset = transform.is_axis_aligned;
 #endif
     // Compute the snapping offset only if the scroll node transform is axis-aligned.
     if (remove_subpx_offset) {