Bug 1487595 - Error out instead of setting EXPAND_LIBS_LIST_STYLE to none. r=froydnj
authorMike Hommey <mh+mozilla@glandium.org>
Fri, 31 Aug 2018 13:55:32 +0900
changeset 434386 0d4ca5c5e71cf331a1c101ad96bf7f56b485cc89
parent 434385 d397dc6aa86679c61e59c3a51ad17421a0f324fe
child 434387 e2531be104190923d29397506ef035eb85ef6ef9
push id34553
push usercsabou@mozilla.com
push dateSat, 01 Sep 2018 09:30:06 +0000
treeherdermozilla-central@2667224d61d0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersfroydnj
bugs1487595, 1429875
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1487595 - Error out instead of setting EXPAND_LIBS_LIST_STYLE to none. r=froydnj Back before expandlibs was removed in bug 1429875, not using list files was supported, but nowadays, it just leads to errors like the following: *** No rule to make target 'libfake_so.list', needed by 'libfake.so'. Stop. We might as well error out during configure, rather than much later during the build. Differential Revision: https://phabricator.services.mozilla.com/D4738
build/autoconf/expandlibs.m4
--- a/build/autoconf/expandlibs.m4
+++ b/build/autoconf/expandlibs.m4
@@ -24,17 +24,17 @@ AC_CACHE_CHECK(what kind of list files a
              dnl first because clang understands @file, but may pass an
              dnl oversized argument list to the linker depending on the
              dnl contents of @file.
              if AC_TRY_COMMAND(${CC-cc} -o conftest${ac_exeext} $CFLAGS $CPPFLAGS $LDFLAGS [-Wl,-filelist,conftest.list] $LIBS 1>&5) && test -s conftest${ac_exeext}; then
                  EXPAND_LIBS_LIST_STYLE=filelist
              elif AC_TRY_COMMAND(${CC-cc} -o conftest${ac_exeext} $CFLAGS $CPPFLAGS $LDFLAGS @conftest.list $LIBS 1>&5) && test -s conftest${ac_exeext}; then
                  EXPAND_LIBS_LIST_STYLE=list
              else
-                 EXPAND_LIBS_LIST_STYLE=none
+                 AC_ERROR([Couldn't find one that works])
              fi
          fi
      else
          dnl We really don't expect to get here, but just in case
          AC_ERROR([couldn't compile a simple C file])
      fi
      rm -rf conftest*])