Bug 1392508 - Don't include nsRect.h, nsSize.h and nsIMemoryReporter.h in MediaData.h as they're unused. r=gerald
authorChris Pearce <cpearce@mozilla.com>
Tue, 22 Aug 2017 03:44:32 +1200
changeset 377145 0cb8d97fe9261df38202ce9eacff788ad49683fa
parent 377144 ac74aef901edd88bc3839a05039e0f9ed644a4a7
child 377146 239440f2b04907e078b01992c633146d657f5554
push id32402
push userarchaeopteryx@coole-files.de
push dateMon, 28 Aug 2017 14:47:04 +0000
treeherdermozilla-central@d5b6d113cf17 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgerald
bugs1392508
milestone57.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1392508 - Don't include nsRect.h, nsSize.h and nsIMemoryReporter.h in MediaData.h as they're unused. r=gerald Including these also causes us to include a bunch of headers about points, margins, and nsISupports/XPCOM/js, which we don't need. MozReview-Commit-ID: 167YidMaeUQ
dom/media/MediaData.h
dom/media/gtest/TestAudioCompactor.cpp
--- a/dom/media/MediaData.h
+++ b/dom/media/MediaData.h
@@ -12,19 +12,17 @@
 #include "TimeUnits.h"
 #include "mozilla/CheckedInt.h"
 #include "mozilla/PodOperations.h"
 #include "mozilla/RefPtr.h"
 #include "mozilla/Span.h"
 #include "mozilla/UniquePtr.h"
 #include "mozilla/UniquePtrExtensions.h"
 #include "mozilla/gfx/Rect.h"
-#include "nsIMemoryReporter.h"
-#include "nsRect.h"
-#include "nsSize.h"
+#include "nsString.h"
 #include "nsTArray.h"
 
 namespace mozilla {
 
 namespace layers {
 class Image;
 class ImageContainer;
 class KnowsCompositor;
--- a/dom/media/gtest/TestAudioCompactor.cpp
+++ b/dom/media/gtest/TestAudioCompactor.cpp
@@ -1,15 +1,16 @@
 /* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
 /* vim: set ts=8 sts=2 et sw=2 tw=80: */
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 #include "gtest/gtest.h"
 #include "AudioCompactor.h"
+#include "nsIMemoryReporter.h"
 
 using mozilla::AudioCompactor;
 using mozilla::AudioData;
 using mozilla::AudioDataValue;
 using mozilla::MediaQueue;
 
 class MemoryFunctor : public nsDequeFunctor {
 public: