Bug 1169632 - Loop conversation name vanishes if the window is detached by dragging. Don't try to set the title in the wrong place - let the detachChatbox code set the title. r=mixedpuppy
authorMark Banner <standard8@mozilla.com>
Fri, 11 Sep 2015 17:14:39 +0100
changeset 262141 0c7ecbc664434f625d2a74349836d6fedfd85075
parent 262140 1b51d0c353153f42c62b4e4ef6ca10fcd93c6f69
child 262142 1199232e985b2b477d770f336af9edc19f004c6c
push id29360
push userphilringnalda@gmail.com
push dateSat, 12 Sep 2015 16:14:08 +0000
treeherdermozilla-central@454b06628c64 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmixedpuppy
bugs1169632
milestone43.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1169632 - Loop conversation name vanishes if the window is detached by dragging. Don't try to set the title in the wrong place - let the detachChatbox code set the title. r=mixedpuppy
browser/base/content/socialchat.xml
--- a/browser/base/content/socialchat.xml
+++ b/browser/base/content/socialchat.xml
@@ -800,20 +800,15 @@
         let winWidth = 400;
         let winHeight = 420;
         // ensure new window entirely within screen
         let left = Math.min(Math.max(eX, sX.value),
                             sX.value + sWidth.value - winWidth);
         let top = Math.min(Math.max(eY, sY.value),
                            sY.value + sHeight.value - winHeight);
 
-        let title = draggedChat.content.getAttribute("title");
-        this.detachChatbox(draggedChat, { screenX: left, screenY: top }).then(
-          chatbox => {
-            chatbox.contentWindow.document.title = title;
-          }
-        );
+        this.detachChatbox(draggedChat, { screenX: left, screenY: top });
         event.stopPropagation();
       ]]></handler>
     </handlers>
   </binding>
 
 </bindings>