Bug 1471028 - fix check for outdated node versions; r=bustage, a=bustage
authorNathan Froyd <froydnj@mozilla.com>
Wed, 04 Jul 2018 07:46:08 -0400
changeset 424977 0c5ad222605bc6579f4e281a30fc55b0634c08e1
parent 424976 cc3401e78e8bbae22e6dbc854e525ceae4923bcf
child 424978 a9dc5dc8e2b8513686ad1b1f28c9e4da6de62226
push id34228
push usernfroyd@mozilla.com
push dateWed, 04 Jul 2018 11:47:10 +0000
treeherdermozilla-central@0c5ad222605b [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbustage, bustage
bugs1471028
milestone63.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1471028 - fix check for outdated node versions; r=bustage, a=bustage MozReview-Commit-ID: 5OlPH2tUACP
build/moz.configure/node.configure
--- a/build/moz.configure/node.configure
+++ b/build/moz.configure/node.configure
@@ -59,15 +59,15 @@ def nodejs_suitability(require, node, ve
         if require:
             raise FatalCheckError(msg)
         else:
             log.warning(msg)
             log.warning('(This will become a fatal error in the near future.)')
             return
 
     if version < MIN_NODE_VERSION:
-        msg = 'NODEJS must point to node %s or newer; %s found' (
-            MIN_NODE_VERSION, node_version)
+        msg = 'NODEJS must point to node %s or newer; %s found' % (
+            MIN_NODE_VERSION, version)
 
         if require:
             raise FatalCheckError(msg)
         else:
             log.warning(msg)