Bug 1590346 - Provide json schema support for measurement units r=octavian_negru,perftest-reviewers,sparky
authorIonut Goldan <igoldan@mozilla.com>
Mon, 04 Nov 2019 14:56:10 +0000
changeset 500386 0c3a12ed20ab80449a103a960ebc7eabe0c9d5f4
parent 500385 345aa7ad3051a3c4c74dab8f6505dc8c8d1248a7
child 500387 e5ca446ceff7f065799431197a6b2a7d68230c4c
push id36763
push userrmaries@mozilla.com
push dateMon, 04 Nov 2019 21:44:06 +0000
treeherdermozilla-central@75a7a3400888 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersoctavian_negru, perftest-reviewers, sparky
bugs1590346
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1590346 - Provide json schema support for measurement units r=octavian_negru,perftest-reviewers,sparky Differential Revision: https://phabricator.services.mozilla.com/D50044
testing/mozharness/external_tools/performance-artifact-schema.json
--- a/testing/mozharness/external_tools/performance-artifact-schema.json
+++ b/testing/mozharness/external_tools/performance-artifact-schema.json
@@ -17,16 +17,22 @@
                 },
                 "value": {
                     "description": "Summary value for subtest",
                     "title": "Subtest value",
                     "type": "number",
                     "minimum": -1000000000000.0,
                     "maximum": 1000000000000.0
                 },
+                "unit": {
+                    "title": "Measurement unit",
+                    "type": "string",
+                    "minLength": 1,
+                    "maxLength": 20
+                },
                 "lowerIsBetter": {
                     "description": "Whether lower values are better for subtest",
                     "title": "Lower is better",
                     "type": "boolean"
                 },
                 "shouldAlert": {
                     "description": "Whether we should alert",
                     "title": "Should alert",
@@ -91,16 +97,22 @@
                     "type": "array"
                 },
                 "value": {
                     "title": "Suite value",
                     "type": "number",
                     "minimum": -1000000000000.0,
                     "maximum": 1000000000000.0
                 },
+                "unit": {
+                    "title": "Measurement unit",
+                    "type": "string",
+                    "minLength": 1,
+                    "maxLength": 20
+                },
                 "lowerIsBetter": {
                     "description": "Whether lower values are better for suite",
                     "title": "Lower is better",
                     "type": "boolean"
                 },
                 "shouldAlert": {
                     "description": "Whether we should alert on this suite (overrides default behaviour)",
                     "title": "Should alert",