Bug 1345791: ICE disconnect state is not a crash. r=bwc
authorNils Ohlmeier [:drno] <drno@ohlmeier.org>
Wed, 29 Mar 2017 16:39:42 -0500
changeset 350525 0c2ca5a4f0a61249c788db3bfe31a9aaa57ae442
parent 350524 3c163f0ba4b714a21c912091c8ac4698890cbc57
child 350526 f28a5dfdfc03feb42075bc29698000c95355683f
push id31576
push userryanvm@gmail.com
push dateThu, 30 Mar 2017 19:18:48 +0000
treeherdermozilla-central@0156a91a9fba [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersbwc
bugs1345791
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1345791: ICE disconnect state is not a crash. r=bwc MozReview-Commit-ID: IwrWVvjkNmX
media/mtransport/nricectx.cpp
--- a/media/mtransport/nricectx.cpp
+++ b/media/mtransport/nricectx.cpp
@@ -1119,17 +1119,18 @@ void NrIceCtx::SetConnectionState(Connec
               time_delta.ToMilliseconds());
         } else {
           Telemetry::Accumulate(
               Telemetry::WEBRTC_ICE_ANSWERER_FAILURE_TIME,
               time_delta.ToMilliseconds());
         }
         break;
       case ICE_CTX_DISCONNECTED:
-        MOZ_CRASH("Transition from checking->disconnected should never happen");
+        // We get this every time an ICE disconnect gets reported.
+        // Do we want a Telemetry probe counting how often this happens?
         break;
       case ICE_CTX_CLOSED:
         // This doesn't seem to be used...
         break;
     }
   }
 
   MOZ_MTLOG(ML_INFO, "NrIceCtx(" << name_ << "): state " <<