Bug 1639381: Add period and newline at the end of scroll-anchor logging statement. r=emilio
authorDaniel Holbert <dholbert@cs.stanford.edu>
Tue, 19 May 2020 23:15:10 +0000
changeset 530954 0b8d520d2aa6ca00f0028426728ac9b5b5d6ed5a
parent 530953 399e60cb2d0bd8b77757525738d8cbb169902b8e
child 530955 837b1bff6998a5a34978777dac555a642fd203bd
push id37435
push userapavel@mozilla.com
push dateWed, 20 May 2020 15:28:23 +0000
treeherdermozilla-central@5415da14ec9a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
bugs1639381
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1639381: Add period and newline at the end of scroll-anchor logging statement. r=emilio This change is for consistency with other similar logging, and to avoid getting unrelated lines of logging concatenated together. Calling this "DONTBUILD" because this is just a small tweak to an (opt-in) debug logging string which probably doesn't get printed on TreeHerder, so there's virtually no chance this could have an impact on any TreeHerder jobs. Differential Revision: https://phabricator.services.mozilla.com/D76061
layout/generic/ScrollAnchorContainer.cpp
--- a/layout/generic/ScrollAnchorContainer.cpp
+++ b/layout/generic/ScrollAnchorContainer.cpp
@@ -252,17 +252,17 @@ void ScrollAnchorContainer::SelectAnchor
   if (CanMaintainAnchor()) {
     MOZ_DIAGNOSTIC_ASSERT(
         !mScrollFrame->mScrolledFrame->IsInScrollAnchorChain(),
         "Our scrolled frame can't serve as or contain an anchor for an "
         "ancestor if it can maintain its own anchor");
     ANCHOR_LOG("Beginning selection.\n");
     mAnchorNode = FindAnchorIn(mScrollFrame->mScrolledFrame);
   } else {
-    ANCHOR_LOG("Skipping selection, doesn't maintain a scroll anchor");
+    ANCHOR_LOG("Skipping selection, doesn't maintain a scroll anchor.\n");
     mAnchorNode = nullptr;
   }
 
   // Update the anchor flags if needed
   if (oldAnchor != mAnchorNode) {
     ANCHOR_LOG("Anchor node has changed from (%p) to (%p).\n", oldAnchor,
                mAnchorNode);