Bug 832683: Match SRTP policy values to enable NACK mode in webrtc r=ekr
authorRandell Jesup <rjesup@jesup.org>
Wed, 23 Jan 2013 16:41:35 -0500
changeset 119621 0b1325001df47d23238b550903d1abcac453560c
parent 119620 70baa7e07838529511d8f0fe6d0693101ee0d4c8
child 119622 4c8d59b07d1676d070367e1216e524944ea8dc54
push id24212
push userrjesup@wgate.com
push dateWed, 23 Jan 2013 22:12:36 +0000
treeherdermozilla-central@0b1325001df4 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersekr
bugs832683
milestone21.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 832683: Match SRTP policy values to enable NACK mode in webrtc r=ekr
media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp
--- a/media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp
+++ b/media/webrtc/signaling/src/mediapipeline/SrtpFlow.cpp
@@ -70,18 +70,18 @@ RefPtr<SrtpFlow> SrtpFlow::Create(int ci
   }
   // This key is copied into the srtp_t object, so we don't
   // need to keep it.
   policy.key = const_cast<unsigned char *>(
       static_cast<const unsigned char *>(key));
   policy.ssrc.type = inbound ? ssrc_any_inbound : ssrc_any_outbound;
   policy.ssrc.value = 0;
   policy.ekt = NULL;
-  policy.window_size = 0;      // Use the default value.
-  policy.allow_repeat_tx = 0;  // TODO(ekr@rtfm.com): revisit?
+  policy.window_size = 1024;   // Use the Chrome value.  Needs to be revisited.  Default is 128
+  policy.allow_repeat_tx = 1;  // Use Chrome value; needed for NACK mode to work
   policy.next = NULL;
 
   // Now make the session
   err_status_t r = srtp_create(&flow->session_, &policy);
   if (r != err_status_ok) {
     MOZ_MTLOG(PR_LOG_ERROR, "Error creating srtp session");
     return NULL;
   }