Bug 1573375 - Normalize paths run-task sets in the environment on Windows. r=tomprince
authorMike Hommey <mh+mozilla@glandium.org>
Fri, 09 Aug 2019 13:57:29 +0900
changeset 488138 0ac9d259e2cc5f298c46ee7ab05ee44a12e35b30
parent 488137 3bfb88dc5a819ea7d9f037050e005b5d882e952c
child 488139 df07c14dac87f7ee61fd356d30889d9f44f13f06
push id36435
push usercbrindusan@mozilla.com
push dateThu, 15 Aug 2019 09:46:49 +0000
treeherdermozilla-central@0db07ff50ab5 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstomprince
bugs1573375
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1573375 - Normalize paths run-task sets in the environment on Windows. r=tomprince Using forward slash for better support in shell scripts. Differential Revision: https://phabricator.services.mozilla.com/D41707
taskcluster/scripts/run-task
--- a/taskcluster/scripts/run-task
+++ b/taskcluster/scripts/run-task
@@ -833,17 +833,19 @@ def main(args):
         os.setresuid(uid, uid, uid)
 
     vcs_checkout_from_args(args, 'gecko')
     vcs_checkout_from_args(args, 'comm')
 
     try:
         for k in ('GECKO_PATH', 'MOZ_FETCHES_DIR', 'UPLOAD_DIR'):
             if k in os.environ:
-                os.environ[k] = os.path.abspath(os.environ[k])
+                # Normalize paths to use forward slashes. Some shell scripts
+                # tolerate that better on Windows.
+                os.environ[k] = os.path.abspath(os.environ[k]).replace(os.sep, '/')
                 print_line(b'setup', b'%s is %s\n' % (
                     k.encode('utf-8'),
                     os.environ[k].encode('utf-8')))
 
         if 'MOZ_FETCHES' in os.environ:
             fetch_artifacts()
 
         return run_and_prefix_output(b'task', task_args, cwd=args.task_cwd)