Bug 1523969 part 9 - Move method definition inline comments to new line in 'hal/'. r=gsvelto
authorRyan Hunt <rhunt@eqrion.net>
Mon, 25 Feb 2019 16:07:35 -0600
changeset 461890 0a3f7bcc8145ef68d331c1a0b6ae1fee587f774e
parent 461889 5b5e6a9942777d6faee07db57fd6b14d465b3ab3
child 461891 240e874ed11862376247ea177a88ddf00924e0da
push id35631
push userrgurzau@mozilla.com
push dateFri, 01 Mar 2019 13:06:03 +0000
treeherdermozilla-central@d4e19870e27f [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersgsvelto
bugs1523969
milestone67.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1523969 part 9 - Move method definition inline comments to new line in 'hal/'. r=gsvelto Differential Revision: https://phabricator.services.mozilla.com/D21109
hal/cocoa/CocoaBattery.cpp
hal/linux/UPowerClient.cpp
--- a/hal/cocoa/CocoaBattery.cpp
+++ b/hal/cocoa/CocoaBattery.cpp
@@ -120,18 +120,18 @@ NS_IMPL_ISUPPORTS(SingletonDestroyer, ns
 NS_IMETHODIMP
 SingletonDestroyer::Observe(nsISupports*, const char* aTopic, const char16_t*) {
   MOZ_ASSERT(!strcmp(aTopic, "xpcom-shutdown"));
   MacPowerInformationService::Shutdown();
   return NS_OK;
 }
 }  // namespace
 
-/* static */ MacPowerInformationService*
-MacPowerInformationService::GetInstance() {
+/* static */
+MacPowerInformationService* MacPowerInformationService::GetInstance() {
   if (sInstance) {
     return sInstance;
   }
 
   sInstance = new MacPowerInformationService();
 
   nsCOMPtr<nsIObserverService> obs = mozilla::services::GetObserverService();
   if (obs) {
--- a/hal/linux/UPowerClient.cpp
+++ b/hal/linux/UPowerClient.cpp
@@ -148,17 +148,18 @@ void GetCurrentBatteryInformation(hal::B
 }
 
 /*
  * Following is the implementation of UPowerClient.
  */
 
 UPowerClient* UPowerClient::sInstance = nullptr;
 
-/* static */ UPowerClient* UPowerClient::GetInstance() {
+/* static */
+UPowerClient* UPowerClient::GetInstance() {
   if (!sInstance) {
     sInstance = new UPowerClient();
   }
 
   return sInstance;
 }
 
 UPowerClient::UPowerClient()
@@ -312,42 +313,43 @@ void UPowerClient::UpdateTrackedDeviceSy
         G_TYPE_STRV, G_TYPE_INVALID);
     dbus_g_proxy_connect_signal(mTrackedDeviceProxy, "PropertiesChanged",
                                 G_CALLBACK(PropertiesChanged), this, nullptr);
   }
 
   g_ptr_array_free(devices, true);
 }
 
-/* static */ void UPowerClient::DeviceChanged(DBusGProxy* aProxy,
-                                              const gchar* aObjectPath,
-                                              UPowerClient* aListener) {
+/* static */
+void UPowerClient::DeviceChanged(DBusGProxy* aProxy, const gchar* aObjectPath,
+                                 UPowerClient* aListener) {
   if (!aListener->mTrackedDevice) {
     return;
   }
 
 #if GLIB_MAJOR_VERSION >= 2 && GLIB_MINOR_VERSION >= 16
   if (g_strcmp0(aObjectPath, aListener->mTrackedDevice)) {
 #else
   if (g_ascii_strcasecmp(aObjectPath, aListener->mTrackedDevice)) {
 #endif
     return;
   }
 
   aListener->GetDevicePropertiesAsync(aListener->mTrackedDeviceProxy);
 }
 
-/* static */ void UPowerClient::PropertiesChanged(DBusGProxy* aProxy,
-                                                  const gchar*, GHashTable*,
-                                                  char**,
-                                                  UPowerClient* aListener) {
+/* static */
+void UPowerClient::PropertiesChanged(DBusGProxy* aProxy, const gchar*,
+                                     GHashTable*, char**,
+                                     UPowerClient* aListener) {
   aListener->GetDevicePropertiesAsync(aListener->mTrackedDeviceProxy);
 }
 
-/* static */ DBusHandlerResult UPowerClient::ConnectionSignalFilter(
+/* static */
+DBusHandlerResult UPowerClient::ConnectionSignalFilter(
     DBusConnection* aConnection, DBusMessage* aMessage, void* aData) {
   if (dbus_message_is_signal(aMessage, DBUS_INTERFACE_LOCAL, "Disconnected")) {
     static_cast<UPowerClient*>(aData)->StopListening();
     // We do not return DBUS_HANDLER_RESULT_HANDLED here because the connection
     // might be shared and some other filters might want to do something.
   }
 
   return DBUS_HANDLER_RESULT_NOT_YET_HANDLED;
@@ -364,18 +366,20 @@ GHashTable* UPowerClient::GetDevicePrope
     HAL_LOG("Error: %s\n", error->message);
     g_error_free(error);
     return nullptr;
   }
 
   return hashTable;
 }
 
-/* static */ void UPowerClient::GetDevicePropertiesCallback(
-    DBusGProxy* aProxy, DBusGProxyCall* aCall, void* aData) {
+/* static */
+void UPowerClient::GetDevicePropertiesCallback(DBusGProxy* aProxy,
+                                               DBusGProxyCall* aCall,
+                                               void* aData) {
   GError* error = nullptr;
   GHashTable* hashTable = nullptr;
   GType typeGHashTable =
       dbus_g_type_get_map("GHashTable", G_TYPE_STRING, G_TYPE_VALUE);
   if (!dbus_g_proxy_end_call(aProxy, aCall, &error, typeGHashTable, &hashTable,
                              G_TYPE_INVALID)) {
     HAL_LOG("Error: %s\n", error->message);
     g_error_free(error);