Bug 812687 part 8: Add a test for "order" on flex items with abspos siblings. r=mats
authorDaniel Holbert <dholbert@cs.stanford.edu>
Wed, 05 Apr 2017 19:31:48 -0700
changeset 351535 0a1df59228cbd98e22f729670b70901164ed8e1f
parent 351534 51504aea09b0792729e49ff82460e41789a520f6
child 351536 001fd3755ac1810318bb7118b96ebbcc2a3e4a83
push id31611
push usercbook@mozilla.com
push dateThu, 06 Apr 2017 10:51:05 +0000
treeherdermozilla-central@950612071c4e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersmats
bugs812687
milestone55.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 812687 part 8: Add a test for "order" on flex items with abspos siblings. r=mats MozReview-Commit-ID: aCBQER5r2G
layout/style/test/mochitest.ini
layout/style/test/test_flexbox_order_abspos.html
--- a/layout/style/test/mochitest.ini
+++ b/layout/style/test/mochitest.ini
@@ -187,16 +187,17 @@ skip-if = toolkit == 'android' #bug 5366
 [test_exposed_prop_accessors.html]
 [test_extra_inherit_initial.html]
 [test_flexbox_child_display_values.xhtml]
 [test_flexbox_flex_grow_and_shrink.html]
 [test_flexbox_flex_shorthand.html]
 [test_flexbox_layout.html]
 support-files = flexbox_layout_testcases.js
 [test_flexbox_order.html]
+[test_flexbox_order_abspos.html]
 [test_flexbox_order_table.html]
 [test_flexbox_reflow_counts.html]
 [test_font_face_parser.html]
 [test_font_family_parsing.html]
 [test_font_feature_values_parsing.html]
 skip-if = stylo # bug 1339656
 [test_font_loading_api.html]
 skip-if = stylo # timeout bug 1328507
copy from layout/style/test/test_flexbox_order.html
copy to layout/style/test/test_flexbox_order_abspos.html
--- a/layout/style/test/test_flexbox_order.html
+++ b/layout/style/test/test_flexbox_order_abspos.html
@@ -1,16 +1,16 @@
 <!DOCTYPE HTML>
 <html>
 <!--
-https://bugzilla.mozilla.org/show_bug.cgi?id=666041
+https://bugzilla.mozilla.org/show_bug.cgi?id=1345873
 -->
 <head>
   <meta charset="utf-8">
-  <title>Test for Bug 666041</title>
+  <title>Test for Bug 1345873</title>
   <script type="application/javascript" src="/tests/SimpleTest/SimpleTest.js"></script>
   <script type="application/javascript" src="/tests/SimpleTest/WindowSnapshot.js"></script>
   <link rel="stylesheet" type="text/css" href="/tests/SimpleTest/test.css"/>
   <style type="text/css">
 
     div.ref {
       display: none;
       height: 30px;
@@ -39,30 +39,46 @@ https://bugzilla.mozilla.org/show_bug.cg
     div#flexContainer {
       display: flex;
       width: 100px;
       height: 30px;
     }
     div#flexContainerParent {
       display: none;
     }
+    .abs {
+      position: absolute !important;
+      width: 15px  !important;
+      height: 15px !important;
+    }
   </style>
 </head>
 <body>
-<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=666041">Mozilla Bug 666041</a>
+<a target="_blank" href="https://bugzilla.mozilla.org/show_bug.cgi?id=1345873">Mozilla Bug 1345873</a>
 <div id="display">
 
   <!-- Reference cases (display:none; only shown during initRefSnapshots) -->
   <div id="references">
     <div class="ref" id="abc"><refA></refA><refB></refB><refC></refC></div>
-    <div class="ref" id="acb"><refA></refA><refC></refC><refB></refB></div>
-    <div class="ref" id="bac"><refB></refB><refA></refA><refC></refC></div>
-    <div class="ref" id="bca"><refB></refB><refC></refC><refA></refA></div>
-    <div class="ref" id="cab"><refC></refC><refA></refA><refB></refB></div>
-    <div class="ref" id="cba"><refC></refC><refB></refB><refA></refA></div>
+    <div class="ref" id="Abc">
+      <refA class="abs"></refA><refB></refB><refC></refC></div>
+    <div class="ref" id="Bac">
+      <refB class="abs"></refB><refA></refA><refC></refC></div>
+    <div class="ref" id="Bca">
+      <refB class="abs"></refB><refC></refC><refA></refA></div>
+    <div class="ref" id="Cab">
+      <refC class="abs"></refC><refA></refA><refB></refB></div>
+    <div class="ref" id="ABc">
+      <refA class="abs"></refA><refB class="abs"></refB><refC></refC></div>
+    <div class="ref" id="ACb">
+      <refA class="abs"></refA><refC class="abs"></refC><refB></refB></div>
+    <div class="ref" id="BCa">
+      <refB class="abs"></refB><refC class="abs"></refC><refA></refA></div>
+    <div class="ref" id="ABC">
+      <refA class="abs"></refA><refB class="abs"></refB><refC class="abs"></refC></div>
   </div>
 
   <div id="flexContainerParent">
     <!-- The flex container that we'll be testing
          (its parent is display:none initially) -->
     <div id="flexContainer">
       <div id="a"></div>
       <div id="b"></div>
@@ -70,69 +86,70 @@ https://bugzilla.mozilla.org/show_bug.cg
     </div>
   </div>
 
 </div>
 <pre id="test">
 <script type="application/javascript">
 "use strict";
 
-/** Test for Bug 666041 **/
+/** Test for Bug 1345873 **/
 
 /* This testcase ensures that we honor the "order" property when ordering
  * flex items within a flex container.
  *
  * Note: The items in this testcase don't overlap, so this testcase does _not_
  * test paint ordering.  It only tests horizontal ordering in a flex container.
  */
 
 // DATA
 // ----
 
 // This will store snapshots of our reference divs
 let gRefSnapshots = {};
 
 // These are the sets of 'order' values that we'll test.
-// The first three values in each array are the 'order' values that we'll
-// assign to elements a, b, and c (respectively).  The final value in each
-// array is the ID of the expected reference rendering.
-let gOrderTestcases = [
-  // The 6 basic permutations:
-  [ 1, 2, 3, "abc"],
-  [ 1, 3, 2, "acb"],
-  [ 2, 1, 3, "bac"],
-  [ 2, 3, 1, "cab"],
-  [ 3, 1, 2, "bca"],
-  [ 3, 2, 1, "cba"],
+// * The first three values in each array are the 'order' values that we'll
+// assign to elements a, b, and c (respectively).
+// * The next value is a string containing the concatenated IDs of any
+// elements that should be absolutely positioned.
+// * The final value in each array is the ID of the expected reference
+// rendering. (By convention, in those IDs, capital = abspos)
+var gOrderTestcases = [
+  // Just one child is abspos:
+  [ 1, 2, 3, "a", "Abc"],
+  [ 1, 2, 3, "b", "Bac"],
+  [ 1, 2, 3, "c", "Cab"],
+  [ 2, 3, 1, "b", "Bca"],
+  [ 3, 1, 1, "b", "Bca"],
 
-  // Test negative values
-  [ 1, -5, -2, "bca"],
-  [ -50, 0, -2, "acb"],
+  // Two children are abspos:
+  // (Note: "order" doesn't influence position or paint order for abspos
+  // children - only for (in-flow) flex items.)
+  [ 1, 2, 3, "ab", "ABc"],
+  [ 2, 1, 3, "ab", "ABc"],
+  [ 1, 2, 3, "ac", "ACb"],
+  [ 3, 2, 1, "ac", "ACb"],
+  [ 3, 2, 1, "bc", "BCa"],
 
-  // Non-integers should be ignored.
-  // (So, they'll leave their div with the initial 'order' value, which is 0.)
-  [ 1,   1.5, 2,   "bac"],
-  [ 2.5, 3.4, 1,   "abc"],
-  [ 0.5, 1,   1.5, "acb"],
-
-  // Decimal values that happen to be equal to integers (e.g. "3.0") are still
-  // <numbers>, and are _not_ <integers>.
-  //  Source: http://www.w3.org/TR/CSS21/syndata.html#value-def-integer
-  // (So, they'll leave their div with the initial 'order' value, which is 0.)
-  // (NOTE: We have to use quotes around "3.0" and "2.0" to be sure JS doesn't
-  // coerce them into integers before we get a chance to set them in CSS.)
-  [ "3.0", "2.0", "1.0", "abc"],
-  [ 3, "2.0", 1, "bca"],
+  // All three children are abspos:
+  // (Rendering always the same regardless of "order" values)
+  [ 1, 2, 3, "abc", "ABC"],
+  [ 3, 1, 2, "abc", "ABC"],
+  [ 3, 2, 1, "abc", "ABC"],
 ];
 
 // FUNCTIONS
 // ---------
 
 function initRefSnapshots() {
-  let refIds = ["abc", "acb", "bac", "bca", "cab", "cba"];
+  let refIds = ["abc",
+                "Abc", "Bac", "Bca", "Cab",
+                "ABc", "ACb", "BCa",
+                "ABC"];
   for (let id of refIds) {
     let elem = document.getElementById(id);
     elem.style.display = "block";
     gRefSnapshots[id] = snapshotWindow(window, false);
     elem.style.display = "";
   }
 }
 
@@ -144,29 +161,35 @@ function complainIfSnapshotsDiffer(aSnap
     todo(false, "TESTCASE: " + compareResult[1]);
     todo(false, "REFERENCE: "+ compareResult[2]);
   }
 }
 
 function runOrderTestcase(aOrderTestcase) {
   // Sanity-check
   ok(Array.isArray(aOrderTestcase), "expecting testcase to be an array");
-  is(aOrderTestcase.length, 4, "expecting testcase to have 4 elements");
+  is(aOrderTestcase.length, 5, "expecting testcase to have 5 elements");
 
   document.getElementById("a").style.order = aOrderTestcase[0];
   document.getElementById("b").style.order = aOrderTestcase[1];
   document.getElementById("c").style.order = aOrderTestcase[2];
 
+  let idsToMakeAbspos = aOrderTestcase[3].split("");
+  for (let absPosId of idsToMakeAbspos) {
+    document.getElementById(absPosId).classList.add("abs");
+  }
+
   let snapshot = snapshotWindow(window, false);
-  complainIfSnapshotsDiffer(snapshot, gRefSnapshots[aOrderTestcase[3]],
+  complainIfSnapshotsDiffer(snapshot, gRefSnapshots[aOrderTestcase[4]],
                             aOrderTestcase);
 
   // Clean up
   for (let id of ["a", "b", "c"]) {
     document.getElementById(id).style.order = "";
+    document.getElementById(id).classList.remove("abs");
   }
 }
 
 // Main Function
 function main() {
   initRefSnapshots();
 
   // un-hide the flex container's parent