Bug 1595256 - Amended grid-*-gap legacy shorthands to invalid properties of non-flex, non-grid, or non-multi-col containers. r=pbro
authorCyferouss <tony@clinky.io>
Tue, 19 Nov 2019 16:55:19 +0000
changeset 502670 098c0e395cc3eec8e0248a0e1941662b4a844030
parent 502669 32eebd872a2879119c2a761f4ab253d3e0e96ee8
child 502671 103fd2f2c4f39d00479386186662e27c578fa23d
push id36821
push userrmaries@mozilla.com
push dateWed, 20 Nov 2019 03:58:07 +0000
treeherdermozilla-central@34cf9c1d48c9 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerspbro
bugs1595256
milestone72.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1595256 - Amended grid-*-gap legacy shorthands to invalid properties of non-flex, non-grid, or non-multi-col containers. r=pbro Differential Revision: https://phabricator.services.mozilla.com/D53753
devtools/server/actors/utils/inactive-property-helper.js
--- a/devtools/server/actors/utils/inactive-property-helper.js
+++ b/devtools/server/actors/utils/inactive-property-helper.js
@@ -95,17 +95,16 @@ class InactivePropertyHelper {
       },
       // Grid container property used on non-grid container.
       {
         invalidProperties: [
           "grid-auto-columns",
           "grid-auto-flow",
           "grid-auto-rows",
           "grid-template",
-          "grid-gap",
           "justify-items",
         ],
         when: () => !this.gridContainer,
         fixId: "inactive-css-not-grid-container-fix",
         msgId: "inactive-css-not-grid-container",
         numFixProps: 2,
       },
       // Grid item property used on non-grid item.
@@ -137,25 +136,35 @@ class InactivePropertyHelper {
       {
         invalidProperties: [
           "align-content",
           "align-items",
           "justify-content",
           "place-content",
           "place-items",
           "row-gap",
+          // grid-*-gap are supported legacy shorthands for the corresponding *-gap properties.
+          // See https://drafts.csswg.org/css-align-3/#gap-legacy for more information.
+          "grid-gap",
+          "grid-row-gap",
         ],
         when: () => !this.gridContainer && !this.flexContainer,
         fixId: "inactive-css-not-grid-or-flex-container-fix",
         msgId: "inactive-css-not-grid-or-flex-container",
         numFixProps: 2,
       },
-      // column-gap and shorthand used on non-grid or non-flex or non-multi-col container.
+      // column-gap and shorthands used on non-grid or non-flex or non-multi-col container.
       {
-        invalidProperties: ["column-gap", "gap"],
+        invalidProperties: [
+          "column-gap",
+          "gap",
+          // grid-*-gap are supported legacy shorthands for the corresponding *-gap properties.
+          // See https://drafts.csswg.org/css-align-3/#gap-legacy for more information.
+          "grid-column-gap",
+        ],
         when: () =>
           !this.gridContainer && !this.flexContainer && !this.multiColContainer,
         fixId:
           "inactive-css-not-grid-or-flex-container-or-multicol-container-fix",
         msgId: "inactive-css-not-grid-or-flex-container-or-multicol-container",
         numFixProps: 3,
       },
       // Inline properties used on non-inline-level elements.