Bug 1467232 - Ensure ping explanation is formatted correctly. r=Dexter
authorJan-Erik Rediger <jrediger@mozilla.com>
Thu, 07 Jun 2018 13:01:51 +0200
changeset 421726 0943910146c42402a548e721fcf86bd4940d4f1f
parent 421725 659052b94cabc97682695960c0c13755e7590613
child 421727 0b9c59172bc14e37aba8cca70f5fbdd30d654307
push id34106
push useraciure@mozilla.com
push dateThu, 07 Jun 2018 21:48:42 +0000
treeherdermozilla-central@68114b4c0d76 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersDexter
bugs1467232
milestone62.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1467232 - Ensure ping explanation is formatted correctly. r=Dexter The "pingDetails" explanation takes only 2 arguments: a link and the name of the ping to be displayed. MozReview-Commit-ID: CxLnHb73YGu
toolkit/content/aboutTelemetry.js
--- a/toolkit/content/aboutTelemetry.js
+++ b/toolkit/content/aboutTelemetry.js
@@ -322,17 +322,17 @@ var PingPicker = {
       let pingTypeText = this._getSelectedPingType();
       controls.classList.remove("hidden");
       pingType.textContent = pingTypeText;
 
       // Change home page text.
       pingName = bundle.formatStringFromName("namedPing", [pingName, pingTypeText], 2);
       pingNameSpan.textContent = pingName;
       let explanation = bundle.GetStringFromName("pingDetails");
-      fragment = BrowserUtils.getLocalizedFragment(document, explanation, pingLink, pingNameSpan, pingTypeText);
+      fragment = BrowserUtils.getLocalizedFragment(document, explanation, pingLink, pingNameSpan);
     } else {
       // Change sidebar heading text.
       controls.classList.add("hidden");
       pingType.textContent = bundle.GetStringFromName("currentPingSidebar");
 
       // Change home page text.
       pingNameSpan.textContent = pingName;
       let explanation = bundle.GetStringFromName("pingDetailsCurrent");