Bug 934676 - Remove unused variable 'extracted' in ClientAuthDataRunnable::RunOnTargetThread. r=keeler
authorRaymond Etornam Agbeame(:retornam) <mozbugs.retornam@gmail.com>
Tue, 15 Apr 2014 15:46:00 +0200
changeset 178755 090ed8ff3c8e67890ec4fc7840089c3f6e2ea89a
parent 178754 b11545d51a15683ea88e955673d664d4b5251f51
child 178756 b1e04ec8d28337bfe26eae57a026ed0c4059a5e8
push id26595
push usercbook@mozilla.com
push dateWed, 16 Apr 2014 12:48:58 +0000
treeherdermozilla-central@f7c4e7719778 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerskeeler
bugs934676
milestone31.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 934676 - Remove unused variable 'extracted' in ClientAuthDataRunnable::RunOnTargetThread. r=keeler
security/manager/ssl/src/nsNSSIOLayer.cpp
--- a/security/manager/ssl/src/nsNSSIOLayer.cpp
+++ b/security/manager/ssl/src/nsNSSIOLayer.cpp
@@ -1870,17 +1870,16 @@ ClientAuthDataRunnable::RunOnTargetThrea
 {
   PLArenaPool* arena = nullptr;
   char** caNameStrings;
   mozilla::pkix::ScopedCERTCertificate cert;
   ScopedSECKEYPrivateKey privKey;
   mozilla::pkix::ScopedCERTCertList certList;
   CERTCertListNode* node;
   ScopedCERTCertNicknames nicknames;
-  char* extracted = nullptr;
   int keyError = 0; // used for private key retrieval error
   SSM_UserCertChoice certChoice;
   int32_t NumberOfCerts = 0;
   void* wincx = mSocketInfo;
   nsresult rv;
 
   // create caNameStrings
   arena = PORT_NewArena(DER_DEFAULT_CHUNKSIZE);
@@ -2208,19 +2207,16 @@ ClientAuthDataRunnable::RunOnTargetThrea
 noCert:
 loser:
   if (mRV == SECSuccess) {
     mRV = SECFailure;
   }
 done:
   int error = PR_GetError();
 
-  if (extracted) {
-    PR_Free(extracted);
-  }
   if (arena) {
     PORT_FreeArena(arena, false);
   }
 
   *mPRetCert = cert.release();
   *mPRetKey = privKey.forget();
 
   if (mRV == SECFailure) {