Bug 875562 - Part 3b: Review fixups; r=me
authorGregory Szorc <gps@mozilla.com>
Wed, 29 Jan 2014 09:46:39 -0800
changeset 166532 09013fef24b123f128bf424822fe4151b8bf32cf
parent 166531 b973195f0aaf72c4c6f49c2c0158b46900dfcfb1
child 166533 7f177e032c15ac8d275ba005122d84a11df65271
push id26128
push userphilringnalda@gmail.com
push dateSun, 02 Feb 2014 17:23:15 +0000
treeherdermozilla-central@5f88d54c28e0 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersme
bugs875562
milestone29.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 875562 - Part 3b: Review fixups; r=me
toolkit/components/crashes/CrashManager.jsm
toolkit/components/crashes/CrashService.js
--- a/toolkit/components/crashes/CrashManager.jsm
+++ b/toolkit/components/crashes/CrashManager.jsm
@@ -161,17 +161,16 @@ let gCrashManager;
 
 /**
  * Obtain the global CrashManager instance used by the running application.
  *
  * CrashManager is likely only ever instantiated once per application lifetime.
  * The main reason it's implemented as a reusable type is to facilitate testing.
  */
 XPCOMUtils.defineLazyGetter(this.CrashManager, "Singleton", function () {
-  Cu.reportError("CrashManager.Singleton accessed!");
   if (gCrashManager) {
     return gCrashManager;
   }
 
   let crPath = OS.Path.join(OS.Constants.Path.userApplicationDataDir,
                             "Crash Reports");
   gCrashManager = new CrashManager({
     pendingDumpsDir: OS.Path.join(crPath, "pending"),
--- a/toolkit/components/crashes/CrashService.js
+++ b/toolkit/components/crashes/CrashService.js
@@ -4,16 +4,21 @@
 
 "use strict";
 
 const {classes: Cc, interfaces: Ci, utils: Cu} = Components;
 
 Cu.import("resource://gre/modules/Services.jsm", this);
 Cu.import("resource://gre/modules/XPCOMUtils.jsm", this);
 
+/**
+ * This component makes crash data available throughout the application.
+ *
+ * It is a service because some background activity will eventually occur.
+ */
 this.CrashService = function () {};
 
 CrashService.prototype = Object.freeze({
   classID: Components.ID("{92668367-1b17-4190-86b2-1061b2179744}"),
   QueryInterface: XPCOMUtils.generateQI([Ci.nsIObserver]),
 
   observe: function (subject, topic, data) {
     switch (topic) {