Bug 1450847 - Fix view parameter class check in ReadableStreamBYOBRequest::constructor r=till
authorJon Coppeard <jcoppeard@mozilla.com>
Tue, 17 Apr 2018 15:32:02 +0200
changeset 414105 079bd3d58e34e91d002f906748be9f62f0aec318
parent 414104 d9eb07a242d4570d97d79f18db8ed79703cfb22b
child 414106 a1ceebb96b78f8cfc82ad4d7fbcc972205213ce9
push id33858
push userncsoregi@mozilla.com
push dateTue, 17 Apr 2018 21:55:44 +0000
treeherdermozilla-central@d6eb5597d744 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstill
bugs1450847
milestone61.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1450847 - Fix view parameter class check in ReadableStreamBYOBRequest::constructor r=till
js/src/builtin/Stream.cpp
testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.dedicatedworker.html.ini
testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.html.ini
testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.serviceworker.https.html.ini
testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.sharedworker.html.ini
--- a/js/src/builtin/Stream.cpp
+++ b/js/src/builtin/Stream.cpp
@@ -3627,17 +3627,17 @@ ReadableStreamBYOBRequest::constructor(J
     controller = &controllerVal.toObject().as<ReadableByteStreamController>();
 
     if (!viewVal.isObject() || !JS_IsArrayBufferViewObject(&viewVal.toObject())) {
         ReportArgTypeError(cx, "ReadableStreamBYOBRequest", "ArrayBuffer view",
                            args.get(1));
         return false;
     }
 
-    RootedArrayBufferObject view(cx, &viewVal.toObject().as<ArrayBufferObject>());
+    Rooted<ArrayBufferViewObject*> view(cx, &viewVal.toObject().as<ArrayBufferViewObject>());
 
     RootedObject request(cx, CreateReadableStreamBYOBRequest(cx, controller, view));
     if (!request)
         return false;
 
     args.rval().setObject(*request);
     return true;
 }
--- a/testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.dedicatedworker.html.ini
+++ b/testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.dedicatedworker.html.ini
@@ -1,13 +1,4 @@
 [construct-byob-request.dedicatedworker.html]
-  disabled:
-    if debug and (os == "win"): https://bugzilla.mozilla.org/show_bug.cgi?id=1420076
-  expected:
-    if debug and not e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86") and (bits == 32): CRASH
-    if debug and e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86_64") and (bits == 64): CRASH
-    if debug and e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86") and (bits == 32): CRASH
-    if debug and not webrender and e10s and (os == "win") and (version == "10.0.15063") and (processor == "x86_64") and (bits == 64): CRASH
-    if debug and not webrender and e10s and (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): CRASH
-    if debug and not webrender and e10s and (os == "mac") and (version == "OS X 10.10.5") and (processor == "x86_64") and (bits == 64): CRASH
   [ReadableStreamBYOBRequest constructor should throw when passed a real ReadableByteStreamController and a real view]
     expected: FAIL
 
--- a/testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.html.ini
+++ b/testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.html.ini
@@ -1,13 +1,4 @@
 [construct-byob-request.html]
-  disabled:
-    if debug and (os == "win"): https://bugzilla.mozilla.org/show_bug.cgi?id=1420076
-  expected:
-    if debug and not e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86") and (bits == 32): CRASH
-    if debug and e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86_64") and (bits == 64): CRASH
-    if debug and e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86") and (bits == 32): CRASH
-    if debug and not webrender and e10s and (os == "win") and (version == "10.0.15063") and (processor == "x86_64") and (bits == 64): CRASH
-    if debug and not webrender and e10s and (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): CRASH
-    if debug and not webrender and e10s and (os == "mac") and (version == "OS X 10.10.5") and (processor == "x86_64") and (bits == 64): CRASH
   [ReadableStreamBYOBRequest constructor should throw when passed a real ReadableByteStreamController and a real view]
     expected: FAIL
 
--- a/testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.serviceworker.https.html.ini
+++ b/testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.serviceworker.https.html.ini
@@ -1,13 +1,4 @@
 [construct-byob-request.serviceworker.https.html]
-  disabled:
-    if debug and (os == "win"): https://bugzilla.mozilla.org/show_bug.cgi?id=1420076
-  expected:
-    if debug and not e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86") and (bits == 32): CRASH
-    if debug and e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86_64") and (bits == 64): CRASH
-    if debug and e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86") and (bits == 32): CRASH
-    if debug and not webrender and e10s and (os == "win") and (version == "10.0.15063") and (processor == "x86_64") and (bits == 64): CRASH
-    if debug and not webrender and e10s and (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): CRASH
-    if debug and not webrender and e10s and (os == "mac") and (version == "OS X 10.10.5") and (processor == "x86_64") and (bits == 64): CRASH
   [ReadableStreamBYOBRequest constructor should throw when passed a real ReadableByteStreamController and a real view]
     expected: FAIL
 
--- a/testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.sharedworker.html.ini
+++ b/testing/web-platform/meta/streams/readable-byte-streams/construct-byob-request.sharedworker.html.ini
@@ -1,13 +1,4 @@
 [construct-byob-request.sharedworker.html]
-  disabled:
-    if debug and (os == "win"): https://bugzilla.mozilla.org/show_bug.cgi?id=1420076
-  expected:
-    if debug and not e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86") and (bits == 32): CRASH
-    if debug and e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86_64") and (bits == 64): CRASH
-    if debug and e10s and (os == "linux") and (version == "Ubuntu 16.04") and (processor == "x86") and (bits == 32): CRASH
-    if debug and not webrender and e10s and (os == "win") and (version == "10.0.15063") and (processor == "x86_64") and (bits == 64): CRASH
-    if debug and not webrender and e10s and (os == "win") and (version == "6.1.7601") and (processor == "x86") and (bits == 32): CRASH
-    if debug and not webrender and e10s and (os == "mac") and (version == "OS X 10.10.5") and (processor == "x86_64") and (bits == 64): CRASH
   [ReadableStreamBYOBRequest constructor should throw when passed a real ReadableByteStreamController and a real view]
     expected: FAIL