Bug 1636652 [wpt PR 23494] - [FlexNG] Change OverrideHeight variant, a=testonly
authorDavid Grogan <dgrogan@chromium.org>
Wed, 13 May 2020 09:49:26 +0000
changeset 531171 06b070586f340407c4911bc70e962f99150b53a0
parent 531170 f18dc1dcd8ec9b50789036f7af5b82856fa3ed7f
child 531172 c48fdd11379deeb353691ccac0ac7cf681e5484f
push id37435
push userapavel@mozilla.com
push dateWed, 20 May 2020 15:28:23 +0000
treeherdermozilla-central@5415da14ec9a [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewerstestonly
bugs1636652, 23494, 1077524, 2191345, 767105
milestone78.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1636652 [wpt PR 23494] - [FlexNG] Change OverrideHeight variant, a=testonly Automatic update from web-platform-tests [FlexNG] Change OverrideHeight variant In LayoutBox::AvailableLogicalHeightUsing, we were using OverrideContainingBlockContentLogicalHeight instead of OverrideContentLogicalHeight for getting the definite height of the flex item. Of the new tests, 004.html worked before this fix but it wasn't obvious that it would. Bug: 1077524 Change-Id: I2968f8e553476df6fa59c2abb74940eb1467f9cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2191345 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#767105} -- wpt-commits: d23d904cc1b805844f232ecde2266b3389da56a0 wpt-pr: 23494
testing/web-platform/tests/css/css-flexbox/grid-flex-item-003.html
testing/web-platform/tests/css/css-flexbox/grid-flex-item-004.html
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-flexbox/grid-flex-item-003.html
@@ -0,0 +1,11 @@
+<!doctype html>
+<link rel="help" href="https://crbug.com/1077524">
+<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
+<meta name="assert" content="Grid item in 0-height grid flex-item doesn't get the flexbox's height." />
+
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="background: green; display: flex; flex-direction: column; width: 100px; height: 100px;">
+  <div style="background: blue; display: grid; grid-template-rows: auto;">
+    <div style="background: red;"></div>
+  </div>
+</div>
new file mode 100644
--- /dev/null
+++ b/testing/web-platform/tests/css/css-flexbox/grid-flex-item-004.html
@@ -0,0 +1,11 @@
+<!doctype html>
+<link rel="help" href="https://crbug.com/1077524">
+<link rel="match" href="../reference/ref-filled-green-100px-square.xht">
+<meta name="assert" content="Grid item in 0-height ortho grid flex-item doesn't get the flexbox's height." />
+
+<p>Test passes if there is a filled green square and <strong>no red</strong>.</p>
+<div style="background: green; display: flex; flex-direction: column; width: 100px; height: 100px;">
+  <div style="background: blue; display: grid; grid-template-rows: auto; writing-mode: vertical-lr;">
+    <div style="background: red;"></div>
+  </div>
+</div>