Bug 1567600 - Part 4: Add aria-label to about:addons more options button r=Gijs,fluent-reviewers,flod
authorMark Striemer <mstriemer@mozilla.com>
Thu, 22 Aug 2019 21:00:09 +0000
changeset 489510 06aca0857b322e1957fa4bdbf9fdc3efae2fd01c
parent 489509 1d8cca181d354840fd5e88f2245db267bb6c6f1d
child 489511 9fe0cd9fb55eb031dd2fc96d1b20f6ddf47e5b96
push id36475
push userncsoregi@mozilla.com
push dateFri, 23 Aug 2019 09:45:38 +0000
treeherdermozilla-central@5df00af5913e [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersGijs, fluent-reviewers, flod
bugs1567600
milestone70.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1567600 - Part 4: Add aria-label to about:addons more options button r=Gijs,fluent-reviewers,flod Differential Revision: https://phabricator.services.mozilla.com/D42680
toolkit/locales/en-US/toolkit/about/aboutAddons.ftl
toolkit/mozapps/extensions/content/aboutaddons.html
--- a/toolkit/locales/en-US/toolkit/about/aboutAddons.ftl
+++ b/toolkit/locales/en-US/toolkit/about/aboutAddons.ftl
@@ -380,16 +380,21 @@ created-by-author = by <a data-l10n-name
 user-count = Users: { $dailyUsers }
 install-extension-button = Add to { -brand-product-name }
 install-theme-button = Install Theme
 # The label of the button that appears after installing an add-on. Upon click,
 # the detailed add-on view is opened, from where the add-on can be managed.
 manage-addon-button = Manage
 find-more-addons = Find more add-ons
 
+# This is a label for the button to open the "more options" menu, it is only
+# used for screen readers.
+addon-options-button =
+    .aria-label = More Options
+
 ## Add-on actions
 report-addon-button = Report
 remove-addon-button = Remove
 disable-addon-button = Disable
 enable-addon-button = Enable
 preferences-addon-button =
     { PLATFORM() ->
         [windows] Options
--- a/toolkit/mozapps/extensions/content/aboutaddons.html
+++ b/toolkit/mozapps/extensions/content/aboutaddons.html
@@ -80,16 +80,17 @@
             </div>
             <!-- This ends up in the tab order when the ellipsis happens, but it isn't necessary. -->
             <span class="addon-description" tabindex="-1"></span>
           </div>
           <div class="more-options-menu">
             <button
               class="more-options-button ghost-button"
               action="more-options"
+              data-l10n-id="addon-options-button"
               aria-haspopup="menu"
               aria-expanded="false"></button>
           </div>
         </div>
         <message-bar class="addon-card-message" align="center" hidden>
           <span></span>
           <button action="link"></button>
         </message-bar>