mozilla-central: changeset 242944:067e21985d8dbd9f5bda06898806bae5542d69e0

author	Brian Grinstead <bgrinstead@mozilla.com>
	Thu, 07 May 2015 11:08:45 -0700
changeset 242944	067e21985d8dbd9f5bda06898806bae5542d69e0
parent 242943	2bda9fb3b5d66a32ba9ed090caa2113a7d9de48e
child 242945	0e5e9c5ac6f360e9606509d88ed863e1332e6e0c
push id	28714
push user	kwierso@gmail.com
push date	Fri, 08 May 2015 17:29:48 +0000
treeherder	mozilla-central@5e8adf0e7f2c [default view] [failures only]
perfherder	[talos] [build metrics] [platform microbench] (compared to previous push)
reviewers	Gijs
bugs	1162490
milestone	40.0a1
first release with	nightly linux32 39dc888ce14c / 40.0a1 / 20150509030210 / files nightly linux64 39dc888ce14c / 40.0a1 / 20150509030210 / files nightly mac 39dc888ce14c / 40.0a1 / 20150509030210 / files nightly win32 8f21d63b310a / 40.0a1 / 20150509081231 / files nightly win64 39dc888ce14c / 40.0a1 / 20150509030210 / files
last release without	nightly linux32 617dbce26726 / 40.0a1 / 20150507030203 / files nightly linux64 617dbce26726 / 40.0a1 / 20150507030203 / files nightly mac 617dbce26726 / 40.0a1 / 20150507030203 / files nightly win32 617dbce26726 / 40.0a1 / 20150507030203 / files nightly win64 617dbce26726 / 40.0a1 / 20150507030203 / files

Bug 1162490 - Only set the transparent accentcolor for Dev Edition theme in Windows;r=Gijs It is causing the drop shadow to disappear on osx 10.9. Windows is the only platform that uses a transparent background on the tabs, so it's the only one that neesd the accentcolor

browser/components/nsBrowserGlue.js

file | annotate | diff | comparison | revisions

--- a/browser/components/nsBrowserGlue.js
+++ b/browser/components/nsBrowserGlue.js
@@ -728,17 +728,19 @@ BrowserGlue.prototype = {
 
 #ifndef RELEASE_BUILD
     let themeName = gBrowserBundle.GetStringFromName("deveditionTheme.name");
     let vendorShortName = gBrandBundle.GetStringFromName("vendorShortName");
 
     LightweightThemeManager.addBuiltInTheme({
       id: "firefox-devedition@mozilla.org",
       name: themeName,
+#ifdef XP_WIN
       accentcolor: "transparent",
+#endif
       headerURL: "resource:///chrome/browser/content/browser/defaultthemes/devedition.header.png",
       iconURL: "resource:///chrome/browser/content/browser/defaultthemes/devedition.icon.png",
       author: vendorShortName,
     });
 #endif
 
 #ifdef MOZ_CRASHREPORTER
     TabCrashReporter.init();