Bug 1552919 - remove unneeded AnimationValueMap uses; r=emilio
authorNathan Froyd <froydnj@mozilla.com>
Mon, 20 May 2019 18:29:41 +0000
changeset 474587 05bb34bb8b9ff565063fc3e652331c0343b36827
parent 474586 9cf745b75ebc43caf7d734ddf1526df2b803a7e2
child 474588 e62a90a57da1f9e2e546376fe317c1850ca2f553
push id36042
push userdvarga@mozilla.com
push dateTue, 21 May 2019 04:19:40 +0000
treeherdermozilla-central@ca560ff55451 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersemilio
bugs1552919
milestone69.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1552919 - remove unneeded AnimationValueMap uses; r=emilio Nightly Rust complains thusly: ``` error: the item `AnimationValueMap` is imported redundantly --> servo/ports/geckolib/glue.rs:629:9 | 104 | use style::properties::animated_properties::{AnimationValue, AnimationValueMap}; | ----------------- the item `AnimationValueMap` is already imported here ... 629 | use style::properties::animated_properties::AnimationValueMap; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: `-D unused-imports` implied by `-D warnings` ``` Remove the local imports to make it happy. Differential Revision: https://phabricator.services.mozilla.com/D31816
servo/ports/geckolib/glue.rs
--- a/servo/ports/geckolib/glue.rs
+++ b/servo/ports/geckolib/glue.rs
@@ -621,17 +621,16 @@ pub extern "C" fn Servo_AnimationCompose
     segment: &structs::AnimationPropertySegment,
     last_segment: &structs::AnimationPropertySegment,
     computed_timing: &structs::ComputedTiming,
     iteration_composite: IterationCompositeOperation,
 ) {
     use style::gecko_bindings::bindings::Gecko_AnimationGetBaseStyle;
     use style::gecko_bindings::bindings::Gecko_GetPositionInSegment;
     use style::gecko_bindings::bindings::Gecko_GetProgressFromComputedTiming;
-    use style::properties::animated_properties::AnimationValueMap;
 
     let property = match LonghandId::from_nscsspropertyid(css_property) {
         Ok(longhand) if longhand.is_animatable() => longhand,
         _ => return,
     };
     let value_map = AnimationValueMap::from_ffi_mut(raw_value_map);
 
     // We will need an underlying value if either of the endpoints is null...
@@ -923,18 +922,16 @@ pub unsafe extern "C" fn Servo_Animation
     AnimationValueMap::drop_ffi(value_map)
 }
 
 #[no_mangle]
 pub extern "C" fn Servo_AnimationValueMap_GetValue(
     raw_value_map: &mut structs::RawServoAnimationValueMap,
     property_id: nsCSSPropertyID,
 ) -> Strong<RawServoAnimationValue> {
-    use style::properties::animated_properties::AnimationValueMap;
-
     let property = match LonghandId::from_nscsspropertyid(property_id) {
         Ok(longhand) => longhand,
         Err(()) => return Strong::null(),
     };
     let value_map = AnimationValueMap::from_ffi_mut(raw_value_map);
 
     value_map
         .get(&property)