Bug 1429857 - Override -moz-appearance on bookmarks popup subviewbuttons, and styles on menuitem-iconic-left;r=dao
authorBrian Grinstead <bgrinstead@mozilla.com>
Wed, 17 Jan 2018 10:19:15 -0800
changeset 399720 05bab8e59cd173a25124cd86eee6e3afa5355c02
parent 399719 7d2d3bffc389019b1aad4bcc6b31bc4e2bbf9026
child 399721 99a87b01a21f5dd73520e05a461e65dadba90dd6
push id33274
push userdluca@mozilla.com
push dateThu, 18 Jan 2018 09:41:57 +0000
treeherdermozilla-central@a9f3d83fec60 [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersdao
bugs1429857, 1420229
milestone59.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 1429857 - Override -moz-appearance on bookmarks popup subviewbuttons, and styles on menuitem-iconic-left;r=dao This is needed because menu.css is now loaded as a document style and rules there are overriding some in panelUI.inc.css. There are plans to deprioritize menu.css in Bug 1420229, at which point this code can be removed. MozReview-Commit-ID: CF9Ixgqob8
browser/themes/shared/customizableui/panelUI.inc.css
--- a/browser/themes/shared/customizableui/panelUI.inc.css
+++ b/browser/themes/shared/customizableui/panelUI.inc.css
@@ -1263,16 +1263,29 @@ toolbarpaletteitem[place="menu-panel"] >
   padding-inline-start: .5em;
 }
 
 .subviewbutton > .menu-iconic-left {
   -moz-appearance: none;
   margin-inline-end: 0;
 }
 
+%ifdef XP_WIN
+/* Overrides from menu.css to prevent items in the bookmarks popup from being too tall.
+   These won't be necessary once menu.css is loaded as a UA style (Bug 1420229). */
+#BMB_bookmarksPopup .subviewbutton > .menu-iconic-left {
+  padding-top: 0;
+  -moz-appearance: none;
+}
+
+#BMB_bookmarksPopup .subviewbutton {
+  -moz-appearance: none;
+}
+%endif
+
 menuitem[checked="true"].subviewbutton > .menu-iconic-left {
   visibility: hidden;
 }
 
 #PanelUI-panicView > .panel-subview-body,
 #PanelUI-panicView {
   overflow: visible;
 }