Bug 913276 - Only install terminal-notifier on OS X 10.8+; r=ted
authorGregory Szorc <gps@mozilla.com>
Tue, 10 Sep 2013 17:09:34 -0700
changeset 146479 057ef596d743e8de54ad812462edebbe98813652
parent 146478 322e3797b68bfa76bf2866879b29f301209ad59b
child 146480 380a028c1a60edc10bab98fb8fef1bc857014d95
push id25261
push usercbook@mozilla.com
push dateWed, 11 Sep 2013 07:31:01 +0000
treeherdermozilla-central@f9e8e8ce552c [default view] [failures only]
perfherder[talos] [build metrics] [platform microbench] (compared to previous push)
reviewersted
bugs913276
milestone26.0a1
first release with
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
last release without
nightly linux32
nightly linux64
nightly mac
nightly win32
nightly win64
Bug 913276 - Only install terminal-notifier on OS X 10.8+; r=ted
python/mozboot/mozboot/osx.py
--- a/python/mozboot/mozboot/osx.py
+++ b/python/mozboot/mozboot/osx.py
@@ -190,25 +190,29 @@ class OSXBootstrapper(BaseBootstrapper):
         self.brew = self.which('brew')
         assert self.brew is not None
 
         installed = self.check_output([self.brew, 'list']).split()
 
         packages = [
             # We need to install Python because Mercurial requires the Python
             # development headers which are missing from OS X (at least on
-            # 10.8).
+            # 10.8) and because the build system wants a version newer than
+            # what Apple ships.
             ('python', 'python'),
             ('mercurial', 'mercurial'),
             ('git', 'git'),
             ('yasm', 'yasm'),
             ('autoconf213', HOMEBREW_AUTOCONF213),
-            ('terminal-notifier', 'terminal-notifier'),
         ]
 
+        # terminal-notifier is only available in Mountain Lion or newer.
+        if self.os_version >= StrictVersion('10.8'):
+            packages.append(('terminal-notifier', 'terminal-notifier'))
+
         printed = False
 
         for name, package in packages:
             if name in installed:
                 continue
 
             if not printed:
                 print(PACKAGE_MANAGER_PACKAGES % ('Homebrew',))